Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Await for GOG uninstaller to finish #3039

Merged
merged 1 commit into from Sep 10, 2023
Merged

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Sep 10, 2023

This prevents an issue when uninstalling a GOG game while at the same time deleting the game prefix.

The uninstaller and the prefix folder deleting was happening in parallel, freezing the uninstaller execution.

Now we first wait until it's done.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj requested review from a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team September 10, 2023 18:11
@arielj arielj merged commit f9f5cef into main Sep 10, 2023
13 checks passed
@arielj arielj deleted the gog-wait-uninstaller branch September 10, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants