Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Show a progress bar in the task bar for various app activity #3086

Merged
merged 13 commits into from Dec 19, 2023

Conversation

0xCmdrKeen
Copy link
Contributor

@0xCmdrKeen 0xCmdrKeen commented Sep 27, 2023

Summary

This shows a progress bar in the application's task bar icon for various background app activity, such as downloading/installing, updating, or launching a game. If any such activity starts, an indeterminate (i.e. spinning) progress bar is shown until the activity either finishes or produces some measurable progress (i.e. downloading a game), at which point the progress is shown using a determinate progress bar.

Here's a short video to demonstrate this:

Recording.2023-09-26.232214.mp4

This should work on all platforms, although there are certain limitations on Linux, see https://www.electronjs.org/docs/latest/api/browser-window#winsetprogressbarprogress-options

Details

An indeterminate progress bar is shown during the following activities:

  • Installing a game (until download progress is available)
  • Updating a game (until download progress is available)
  • Moving a game (until copy progress is available)
  • Verifying and repairing a game
  • Uninstalling a game
  • Syncing cloud saves
  • Launching a game

A determinate progress bar is shown whenever a download is in progress (i.e. during installation or update), or when moving a game. Whenever a given activity finishes, the progress bar is removed again.

Checklist

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

src/backend/main_window.ts Outdated Show resolved Hide resolved
src/backend/utils.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. It seems it doesn't work on linux with cinnamon as the DE so I can't really test this so I'll leave this for other people to properly test it.

@arielj arielj changed the title Show a progress bar in the task bar for various app activity [UI] Show a progress bar in the task bar for various app activity Oct 7, 2023
@Etaash-mathamsetty
Copy link
Member

Etaash-mathamsetty commented Oct 10, 2023

Supporting only unity desktop is unacceptable in 2023, let me see what I can do to fix this
nvm the same api is supported by kde as well, the docs are lying :p

@Etaash-mathamsetty
Copy link
Member

ok unfortunately it doesn't work on linux at all, but that's ok

@flavioislima
Copy link
Member

This one should be ready to merge after the conflicts are fixed. :)

@0xCmdrKeen
Copy link
Contributor Author

@flavioislima I fixed the conflicts but somehow the build is still stuck in CI 10 hours later, any idea what's wrong with it?

@flavioislima
Copy link
Member

@flavioislima I fixed the conflicts but somehow the build is still stuck in CI 10 hours later, any idea what's wrong with it?

Can you trigger the branch update? this will trigger the workflows.

@flavioislima
Copy link
Member

flavioislima commented Dec 4, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@0xCmdrKeen
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@flavioislima
Copy link
Member

@0xCmdrKeen I think there is an lint issue now on main.ts.

@0xCmdrKeen
Copy link
Contributor Author

Sorry for the force push, looks like I may have messed up the CLA in the process. Can you pls fix it?

@arielj
Copy link
Collaborator

arielj commented Dec 16, 2023

Sorry for the force push, looks like I may have messed up the CLA in the process. Can you pls fix it?

can you reply again with the comment to agree with the CLA? that can probably fix it

@0xCmdrKeen
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@arielj arielj merged commit 6382777 into Heroic-Games-Launcher:main Dec 19, 2023
9 checks passed
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants