[Fix] Installation fail when sdlList has empty elements #3087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filter sdlList in order to remove empty elements to avoid installation failures.
|
How can I test this issue? |
flavioislima
approved these changes
Sep 29, 2023
flavioislima
merged commit 6b62336
into
Heroic-Games-Launcher:main
11 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Fix] Installation fail when sdlList has empty elements
It fixes an install bug on Kerbal Space Program and probably other games (I haven't any game that can select some specific downloads).
Use the following Checklist if you have changed something on the Backend or Frontend: