Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type errors on Jest functions in VS Code #3088

Merged

Conversation

0xCmdrKeen
Copy link
Contributor

@0xCmdrKeen 0xCmdrKeen commented Sep 27, 2023

This fixes a misconfiguration in tsconfig.json which leads to Jest functions such as describe(), expect(), etc. to not be recognized in VS Code.

Before

image

After

image

Checklist

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for fixing it.

@flavioislima flavioislima merged commit bc93618 into Heroic-Games-Launcher:main Sep 29, 2023
13 checks passed
@0xCmdrKeen 0xCmdrKeen deleted the fix/tsconfig.json branch September 30, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants