Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech] Simplify our E2E tests #3213

Merged
merged 1 commit into from
Dec 18, 2023
Merged

[Tech] Simplify our E2E tests #3213

merged 1 commit into from
Dec 18, 2023

Conversation

CommandMC
Copy link
Collaborator

Our E2E test configuration, while being very robust, was a bit overkill for what we're doing with it. Instead of running the tests in a Docker container to isolate them, we can simply set Heroic's configuration directory to a temporary one. In addition, the "packaged" and "dev" tests only differ slightly (one having Heroic's code in the build directory, while the other has it zipped up in a single file somewhere in dist), but this difference is not significant enough to warrant two separate test runs IMO

I hope that by making it easier to run these tests, we can start to use them properly in the future


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label Nov 5, 2023
@CommandMC CommandMC self-assigned this Nov 5, 2023
@CommandMC CommandMC changed the title Simplify our E2E tests [Tech] Simplify our E2E tests Nov 5, 2023
@CommandMC CommandMC force-pushed the tech/playwright branch 2 times, most recently from 7761dcb to 8087913 Compare November 8, 2023 10:42
@CommandMC CommandMC requested review from a team, arielj, flavioislima, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team November 8, 2023 11:50
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@CommandMC CommandMC force-pushed the tech/playwright branch 2 times, most recently from 7be88a5 to c4794c6 Compare December 18, 2023 17:13
@CommandMC CommandMC merged commit 9897a39 into main Dec 18, 2023
9 checks passed
@CommandMC CommandMC deleted the tech/playwright branch December 18, 2023 17:22
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants