[improv]: electron side changes to window behavior

[imLinguin]

window now has a background which should prevent flashing of white,
window is shown after its contents are loaded - removed our custom loadingScreenReady event

additionally I replaced deprecated protocol.registerStringProtocol in favor of protocol.handle

Use the following Checklist if you have changed something on the Backend or Frontend:

• Tested the feature and it's working on a current and clean install.
• Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
• Created / Updated Tests (If necessary)
• Created / Updated documentation (If necessary)

[arielj]

I think we need to find a different solution because the problem seems to be that the show: false option we use when we initialize the window is not really working for some reason, because the our code is saying "start hidden, and only show the window once the frontend tells you the loading screen of heroic is displayed" but then the window is displayed way earlier than that.

This pr is kinda working around that issue but not fully solving it, that hardcoded color is not great (cause now the page wont blink, but it will start black and then change to another color).

I played around and seems like the issue is this call to maximize() https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/blob/main/src/backend/main_window.ts#L89

We should wait until the application is ready and the window is displayed to decide if it should be maximized instead. Because I also noticed the blinking doesn't seem to happen if the app is not maximized when closed.

[arielj]

related to the removal of the loadingScreenReady event, maybe it can be replaced with https://www.electronjs.org/docs/latest/api/browser-window#event-ready-to-show instead of did-finish-load?

I'm not sure about that change though, the different between the custom event we have and the electron events is that ours should wait until the loading screen is ready, and the electron one doesn't know about the loading screen and it can show the app before that (without a blink, but also without the loading screen animation)

[imLinguin]

Indeed, maximize causes the window to show. Will fix that...

I'm not sure about that change though

I think it should be fine, the loading indicator is the first thing that displays on the page after being "loaded".

[arielj]

Looks good to me!