Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Show game title in uninstall dialog #3338

Merged
merged 1 commit into from Jan 1, 2024
Merged

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Dec 21, 2023

When uninstalling a native game, there's no mention of the game that is going to be uninstalled:

Captura de pantalla de 2023-12-20 22-38-42

This can be problematic, because if a user clicks the wrong card to uninstall a game, they can end up uninstalling the wrong one.

Also the copy is confusing Do you want to uninstall this game? but it doesn't say which

This PR adds the title of the game in the message, so it's more clear:

Captura de pantalla de 2023-12-20 22-49-22


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Dec 21, 2023
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team December 21, 2023 01:53
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small but really nice change! 🗡️

@arielj arielj merged commit 9e11f57 into main Jan 1, 2024
9 checks passed
@arielj arielj deleted the uninstall-dialog-title branch January 1, 2024 22:59
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants