Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Improvements when using a controller to navigate the interface #3354

Merged
merged 2 commits into from Jan 1, 2024

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Dec 27, 2023

This PR improves the UX of heroic with a controller with a few tweaks:

  • Pressing the B button (in the steam deck layout, I think it's O if using a PS controller) now closes any dialog, not only the install dialog, and it doesn't go back in history if a dialog is open

This was really annoying, now we can press B to close the Settings dialog, Categories dialog, or the Uninstall dialog for example

  • After closing a dialog, the element that was focused before opening it gains focus again

this was REALLY annoying, it feels way better now, for example when opening the settings or logs for a card, after closing the dialog we are still focused on the same card instead of nowhere

  • When moving the focus in the library, now cards are scrolled into view so they are completely visible

this fixes an issue that when you were at the top or bottom of the screen, you had to do a few more moves to actually get the screen to scroll before the focus changes to the next element


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Dec 27, 2023
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team December 27, 2023 03:02
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@arielj arielj merged commit 410568e into main Jan 1, 2024
9 checks passed
@arielj arielj deleted the controller-improvements branch January 1, 2024 23:00
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants