Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Ignore gamescope if enabled and not found instead of failing #3367

Merged
merged 2 commits into from Dec 31, 2023

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Dec 30, 2023

This PR fixes #3341

Instead of failing with an error, ignore the gamescope setup if enabled but not found.

This can happen if gamescope was configured for a game and then uninstalled.

With this change it will just show a warning in the logs and still run the game as if the setting was disabled.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Dec 30, 2023
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team December 30, 2023 23:32
Copy link
Member

@Etaash-mathamsetty Etaash-mathamsetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this diff is hard to read but if I read it right it looks fine

@arielj
Copy link
Collaborator Author

arielj commented Dec 31, 2023

this diff is hard to read but if I read it right it looks fine

yeah, github is trying to be too smart, I just changed the return with a logWarning and moved the rest into an else (just added indentation to most of the lines there), github is going crazy but there's no other change on that part of the code apart of the extra indentation

@arielj arielj merged commit be02ff9 into main Dec 31, 2023
9 checks passed
@arielj arielj deleted the handle-uninstalled-gamescope branch December 31, 2023 05:30
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Dec 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uninstalling Gamescope can restrict access to games through GUI
2 participants