[UX] Allow setting offline mode even if game does not have the metadata #3385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielj
requested review from
a team,
flavioislima,
CommandMC,
Etaash-mathamsetty,
Nocccer and
imLinguin
and removed request for
a team
arielj
commented
Jan 4, 2024
| } | ||
| logWarning( | ||
| 'Offline Mode is on but the game does not allow offline mode explicitly.' | ||
| ) |
There was a problem hiding this comment.
we don't stop the launching of the game, but we still log this information cause it's important
flavioislima
reviewed
Jan 5, 2024
| @@ -26,17 +28,28 @@ const OfflineMode = () => { | |||
|
|
|||
| const [offlineMode, setOfflineMode] = useSetting('offlineMode', false) | |||
|
|
|||
| if (isDefault || !canRunOffline) { | |||
| if (isDefault) { | |||
There was a problem hiding this comment.
This feature is for Epic games only, right? because GOG will work fine offline since they don't have DRM. Same for Amazon games. So we could hide it for GOG or disable it and show a information about it.
There was a problem hiding this comment.
I changed this to only show the option for Epic games.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3383
Some games seem to not have the
CanRunOfflinemetadata but still work fine in offline mode. This PR allows users to toggle that on so they can still try to run the game.When the option is turned on and the game does not allow offline mode, this warning is displayed:
This will also solve a problem that users sometimes can't find the option and they ask over Discord. Now the option will be always there. In some cases it may not work but we have the warning to let users know it's not heroic's fault but the game not supporting offline mode.
Use the following Checklist if you have changed something on the Backend or Frontend: