Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert logging if the EOS overlay is enabled #3404

Merged
merged 1 commit into from
Jan 7, 2024
Merged

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Jan 7, 2024

In a previous PR I added a line to log if the EOS overlay is enabled or not: this https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/pull/3394/files#diff-3b36a7de185377bbb618ac5e7bc20b0780c6ea78b5d5ac53c7b9a7469448a988R429-R437

This works fine when the prefix is already created but produces an error when the prefix is not ready yet. We have to log this information after making sure the prefix is initialized.

I'll revert this change for now since this other PR #3356 will enable the EOS overlay by default anyway

We can include this in the log in the future (I just don't want this to be a blocker or a problem for a release).


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jan 7, 2024
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team January 7, 2024 00:25
Copy link
Member

@Etaash-mathamsetty Etaash-mathamsetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, no need to log it if it's installed already

@arielj arielj merged commit f6ef1bf into main Jan 7, 2024
9 checks passed
@arielj arielj deleted the do-not-log-eos-status branch January 7, 2024 01:03
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants