Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Proton with ESYNC/FSYNC #3676

Merged
merged 4 commits into from Apr 6, 2024
Merged

[Fix] Proton with ESYNC/FSYNC #3676

merged 4 commits into from Apr 6, 2024

Conversation

CommandMC
Copy link
Collaborator

Multiple little things amounted to Proton no longer being usable while ESYNC/FSYNC were turned on. This resolves those little things by (1) setting the correct env vars when launching Winetricks and (2) no longer launching Winetricks on game launch

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label Apr 4, 2024
@CommandMC CommandMC self-assigned this Apr 4, 2024
arielj
arielj approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

it prints the winetricks packages as expected and I tried running a game a few times with proton and no issues

src/backend/tools/index.ts Outdated Show resolved Hide resolved
@CommandMC @arielj
Fix typo
2dd3067 
Co-authored-by: Ariel Juodziukynas <arieljuod@gmail.com>
@flavioislima flavioislima merged commit 7e320ac into main Apr 6, 2024
9 checks passed
@flavioislima flavioislima deleted the fix/proton-launch branch April 6, 2024 10:57
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arielj arielj arielj approved these changes

Assignees

@CommandMC CommandMC

Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CommandMC @arielj @flavioislima