New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Exp]: UMU support #3724
base: main
Are you sure you want to change the base?
[Exp]: UMU support #3724
Conversation
…uncher into ulwgl
…uncher into ulwgl
useful for use cases where we want to make sure that data won't be removed when offline etc.. in case of ULWGL we invalidate entries that are null
…uncher into ulwgl
Using this branch, I noticed the umu runtime isn't downloaded at ~/.config/heroic/tools/runtimes from the Lutris API when the checkbox Use UMU as Proton runtime is checked. Is this intended or are users supposed build it and put it in that directory themselves? |
if (wrappers.length) { | ||
bin = wrappers.shift()! | ||
commandParts.unshift(...wrappers, wineBin) | ||
if (umuSupported) { | ||
const umuBin = join(runtimePath, 'umu', 'umu-run') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, you can execute umu_run.py instead, which is more direct and what Lutris does
wait: haveToWait, | ||
gameSettings: settings, | ||
protonVerb: 'run', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, if you omit the verb, umu will default to using waitforexitandrun
verb which will block users from running more than 1 game in the same prefix. However, if heroic wants to allow users to run more than 1 game, then you could default to runinprefix
.
ret.STEAM_COMPAT_DATA_PATH = winePrefix | ||
ret.PROTONPATH = dirname(gameSettings.wineVersion.bin) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you choose not to set this, it will cause umu download the latest UMU-Proton and setting PROTONPATH=GE-Proton, will cause it to download the latest GE-Proton.
When umu is configured as the runtime, perhaps another option can be added to the dropdown list as the first option (e.g., UMU-Latest)?
that feature is not implemented yet, i simply just made it work again and haven't done anything on top of that yet |
Experimental feature with UMU support. The feature is enabled by default.
Requires user to manually put
umu-run
inside$XDG_CONFIG_HOME/heroic/tools/runtimes/umu
based on: #3480
Use the following Checklist if you have changed something on the Backend or Frontend: