Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exp]: UMU support #3724

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

[Exp]: UMU support #3724

wants to merge 17 commits into from

Conversation

Etaash-mathamsetty
Copy link
Member

@Etaash-mathamsetty Etaash-mathamsetty commented Apr 27, 2024

Experimental feature with UMU support. The feature is enabled by default.

Requires user to manually put umu-run inside $XDG_CONFIG_HOME/heroic/tools/runtimes/umu

based on: #3480

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@R1kaB3rN
Copy link

Using this branch, I noticed the umu runtime isn't downloaded at ~/.config/heroic/tools/runtimes from the Lutris API when the checkbox Use UMU as Proton runtime is checked. Is this intended or are users supposed build it and put it in that directory themselves?

if (wrappers.length) {
bin = wrappers.shift()!
commandParts.unshift(...wrappers, wineBin)
if (umuSupported) {
const umuBin = join(runtimePath, 'umu', 'umu-run')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, you can execute umu_run.py instead, which is more direct and what Lutris does

wait: haveToWait,
gameSettings: settings,
protonVerb: 'run',
Copy link

@R1kaB3rN R1kaB3rN Apr 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, if you omit the verb, umu will default to using waitforexitandrun verb which will block users from running more than 1 game in the same prefix. However, if heroic wants to allow users to run more than 1 game, then you could default to runinprefix.

ret.STEAM_COMPAT_DATA_PATH = winePrefix
ret.PROTONPATH = dirname(gameSettings.wineVersion.bin)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you choose not to set this, it will cause umu download the latest UMU-Proton and setting PROTONPATH=GE-Proton, will cause it to download the latest GE-Proton.

When umu is configured as the runtime, perhaps another option can be added to the dropdown list as the first option (e.g., UMU-Latest)?

@Etaash-mathamsetty
Copy link
Member Author

Etaash-mathamsetty commented Apr 30, 2024

Using this branch, I noticed the umu runtime isn't downloaded at ~/.config/heroic/tools/runtimes from the Lutris API when the checkbox Use UMU as Proton runtime is checked. Is this intended or are users supposed build it and put it in that directory themselves?

that feature is not implemented yet, i simply just made it work again and haven't done anything on top of that yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants