-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GOG]: use native builds of ScummVM and DOSBox when available #3797
base: main
Are you sure you want to change the base?
Conversation
update gogdl to 1.1.0
Would it make sense to also look for DOSBox-X? I'm not a DOSBox-X partisan myself, but it definitely has its adherents, and I can't think of any reason it couldn't also be used. This would necessitate searching for |
I seem to be unable to run Alone in the Dark with DOSBox-X flatpak. It complains about missing CD-ROM driver, similarily to We may also need to add additional |
Ah, right, DOSBox Staging is more forgiving when it comes to path matching. Makes sense. |
Arch's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this with a couple games and it does appear to be working fine.
Could you link to the commit hash of gogdl we're now using? I assume it's 7c9a6f4
?
I just found out this breaks compatibility with Diablo |
Tested with
Alone in the Dark 1
(dosbox) andBeneath the Steel Sky
(scummvm)gogdl will pick available versions with following conditions
possible executables gogdl will look for
io.github.dosbox-staging
dosbox
org.scummvm.ScummVM
scummvm
when gogdl is in flatpak container it will attempt to call
flatpak-spawn
available throughorg.freedesktop.Flatpak
session bus.If none of the above are available default wine runner will be called
updated to gogdl 1.1.0 that includes this change
Use the following Checklist if you have changed something on the Backend or Frontend: