Get the desktop folder from the system instead of hardcoding '/Desktop' #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielj
changed the title
electron/constants.ts
Outdated
| @@ -15,10 +16,24 @@ function getLegendaryBin(){ | |||
| return bin | |||
| } | |||
|
|
|||
| // Get the "Desktop" directory with multilingual support, fallback to "~/Desktop" | |||
| function getDesktopPath() { | |||
There was a problem hiding this comment.
Instead of using this you can simply get the desktop folder using:
app.getPath('desktop') importing app from electron.
There was a problem hiding this comment.
oh, first time ever using electron, I didn't know this, thanks! I'll update the PR
There was a problem hiding this comment.
I couldn't use app.getPath('desktop') here in the constants.ts file because electron's app is undefined during tests and it makes the tests fail, so I used that directly on the games.ts file
flavioislima
requested changes
Oct 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
xdg-user-dir DESKTOPon linux systems to get the correct Desktop folder path that depends on the system language.My system is in spanish, so my
Desktopfolder is actuallyEscritorio, using thexdg-user-dircommand returns the full path to that directory.This is only implemented for linux since adding shortcuts to desktop is only implemented on linux.
Closes #721
I couldn't add a test since I would have to stub the system command somehow which feels too hacky, but I accept any suggestion on how to add a test for this fix!
Use the following Checklist if you have changed something on the Backend or Frontend: