Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[General] Auto-Update In the background #830

Merged
merged 16 commits into from Apr 11, 2022
Merged

[General] Auto-Update In the background #830

merged 16 commits into from Apr 11, 2022

Conversation

ghost
Copy link

@ghost ghost commented Dec 29, 2021 •
edited by flavioislima

This PR implements Auto-update in the background for the following platforms:

  • macOS: DMG.
  • Linux: AppImage.
  • Windows: NSIS.

@ghost ghost added the pr:wip WIP, don't merge. label Dec 29, 2021
adityaruplaha
adityaruplaha previously approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@adityaruplaha adityaruplaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in theory, I can't test this right now though.

@flavioislima flavioislima added abandoned and removed pr:wip WIP, don't merge. labels Mar 21, 2022
@flavioislima flavioislima added pr:wip WIP, don't merge. and removed abandoned labels Apr 6, 2022
@flavioislima flavioislima linked an issue Apr 11, 2022 that may be closed by this pull request
Automatic updating in the background #336
Closed
@flavioislima flavioislima changed the title Update system [General] Auto-Update In the background Apr 11, 2022
@flavioislima flavioislima added pr:ready-for-review Feature-complete, ready for the grind! :P pr:ready-to-merge This PR is fully ready for merge. and removed pr:wip WIP, don't merge. pr:ready-for-review Feature-complete, ready for the grind! :P labels Apr 11, 2022
@flavioislima
Copy link
Member

Tested on all platforms and the update works pretty well.
Added a few dialogs to give the user choice and feedback

@flavioislima flavioislima merged commit fe6bb87 into main Apr 11, 2022
@flavioislima flavioislima deleted the update-system branch April 11, 2022 16:31
@ghost
Copy link
Author

ghost commented Apr 11, 2022

🎉

CommandMC pushed a commit to CommandMC/HeroicGamesLauncher that referenced this pull request Apr 13, 2022
@flavioislima @CommandMC
[General] Auto-Update In the background (Heroic-Games-Launcher#830)
ddbf8f3 
* Add electron-updater module

* Add update system

* Lint

* Use once instead of on

* Use old checkForUpdates for IPC call 'checkVersion'

* Lint

* update yarn lock

* fix: import and install function

* feat: removed oud update system

* feat: improved dialog

* fix: typo

* feat: add error dialog

Co-authored-by: Flavio Lima <flavioislima@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr:ready-to-merge This PR is fully ready for merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automatic updating in the background
2 participants
@flavioislima @adityaruplaha