Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[General] Add timestamp and relined logs #939

Merged
merged 4 commits into from Jan 30, 2022
Merged

[General] Add timestamp and relined logs #939

merged 4 commits into from Jan 30, 2022

Conversation

Nocccer
Copy link
Collaborator

@Nocccer Nocccer commented Jan 30, 2022 •
edited

  • Added timestamp for each logged message
  • Lined logs so it looks similiar to a table

image

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@Nocccer Nocccer added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jan 30, 2022
flavioislima
flavioislima reviewed Jan 30, 2022
View reviewed changes
electron/legendary/library.ts Outdated Show resolved Hide resolved
electron/logger/logger.ts Outdated Show resolved Hide resolved
flavioislima
flavioislima approved these changes Jan 30, 2022
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good 👍🏽

@Nocccer Nocccer merged commit 21c0dfb into main Jan 30, 2022
@Nocccer Nocccer deleted the timestamp-logs branch January 30, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavioislima flavioislima flavioislima approved these changes

@CommandMC CommandMC Awaiting requested review from CommandMC

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nocccer @flavioislima