Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix month value error #29

Merged
merged 2 commits into from Mar 27, 2023
Merged

Fix month value error #29

merged 2 commits into from Mar 27, 2023

Conversation

imLinguin
Copy link
Member

Heroic-Games-Launcher/HeroicGamesLauncher#2541

This PR is an attempt to fix the issue

@imLinguin imLinguin requested a review from arielj March 25, 2023 23:20
arielj
arielj approved these changes Mar 26, 2023
View reviewed changes
Copy link
Contributor

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me codewise, I don't have any way to reproduce the problem

I wonder if the user reporting the issue was able to test this at some point to confirm it's not crashing (I don't see that in the heroic issue though)

@imLinguin imLinguin merged commit cde0526 into main Mar 27, 2023
3 checks passed
@imLinguin imLinguin deleted the fix/date_error branch March 27, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielj arielj arielj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@imLinguin @arielj