Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples lose state #42

Closed
henris42 opened this issue Aug 10, 2019 · 3 comments
Closed

examples lose state #42

henris42 opened this issue Aug 10, 2019 · 3 comments

Comments

@henris42
Copy link

Hi,

I was tinkering with the examples, using rocket frontend. I tried to quickly integrate a 3rd party service - everything work to the point after accept/deny where the system redirects back to the service. The issue is that "state" is missing from the redirecting URL. (3rd part software sets it correctly, it continues ok if I add it manually..)

Any pointers how to make it work?

@henris42 henris42 added the bug label Aug 10, 2019
@HeroicKatora
Copy link
Owner

HeroicKatora commented Aug 10, 2019

The 'consent' page in the example seems to not set the state parameter for the POST on clicking the 'Accept' button since it uses a hardcode url (this one).

This seems to be an architectural deficiency since the state is not passed to check_consent so that it is not possible to assemble the form target url from the provided parameters.

As a workaround, it would be possible to extract the state parameter from window.location.search in js on the page. (I'm no frontend expert so this is just an idea).

@henris42
Copy link
Author

OK thanks for the info!

I think correct way to fix is to improve check_consent. In my real project I need a completely different consent mechanish anyways so I'd appreciate any pointers to get started on that!

@HeroicKatora
Copy link
Owner

This should no longer be the case since #110 .

Version Enstatite automation moved this from Breaking cleanup to Done Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

2 participants