Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for 0.5 #103

Closed
2 tasks done
Geobert opened this issue Jul 30, 2020 · 8 comments
Closed
2 tasks done

Tracking issue for 0.5 #103

Geobert opened this issue Jul 30, 2020 · 8 comments

Comments

@Geobert
Copy link
Contributor

Geobert commented Jul 30, 2020

Once the async work has landed, what are the next steps in order to stabilize 0.5?

Known interface deficiencies:

@Geobert
Copy link
Contributor Author

Geobert commented Sep 1, 2020

Now that async is merged, what do we need to have a 0.5 published on crates.io?

@HeroicKatora
Copy link
Owner

I'll cut another pre-release tonight and when I had time to ensure that I didn't overlook any interface changes that are compatibility risks then a full release of 0.5 and release notes etc. (this weekend, maybe).

@Geobert
Copy link
Contributor Author

Geobert commented Sep 2, 2020

Thank you, I though there were more work planned to have a 0.5 live ready :)

@HeroicKatora
Copy link
Owner

HeroicKatora commented Sep 2, 2020

There's probably one necessary more small change after the pre-release: Encapsulating the parameter to the solicitor to ensure forward compatibility with introducing some additional state information in a future minor release. (Solving #42 in the long run)

@Geobert
Copy link
Contributor Author

Geobert commented Sep 3, 2020

Oh yes this issue, I have implemented a work around but I'm just realizing it won't work: I stored state in a HashMap with client_id as the key. Which will fails on multi requests from the same client…

@HeroicKatora HeroicKatora mentioned this issue Sep 25, 2020
9 tasks
@Geobert
Copy link
Contributor Author

Geobert commented Oct 2, 2020

Congratulation for 0.5! Didn't notice it was out 5 days ago already :D

@HeroicKatora
Copy link
Owner

Thanks, it literally wouldn't have been possible without You.

@Geobert
Copy link
Contributor Author

Geobert commented Oct 2, 2020

Thanks, it literally wouldn't have been possible without You.

You're welcome! We needed it and that's how Open Source works ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants