New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add serde_urlencoded to db-example Cargo.toml #128
Conversation
I wonder what's the point here as nothing depends on it directly? To influence version resolution of |
That is true. However when I tried to Listing it fixed it for me. But you are right about there has not been an apparent |
Before I retract the pull request, I guess the problem exists in warning: `oxide-auth-actix` (lib) generated 1 warning
Compiling db-example v0.1.0 (/home/jasper/Projects/jaztec/oxide-auth/oxide-auth-db/examples/db-example)
error[E0433]: failed to resolve: use of undeclared crate or module `serde_urlencoded`
--> oxide-auth-db/examples/db-example/src/../../../../examples/support/generic.rs:80:9
|
80 | serde_urlencoded::to_string(extra).unwrap(),
| ^^^^^^^^^^^^^^^^ use of undeclared crate or module `serde_urlencoded`
The listing inside the But again, like I said. I'm just starting out with rust and am probably looking at the problem the wrong way. |
Reopened just for the sake of thinking it being directly required anyway 😄 |
Huh, I was running on the assumption that CI would have complained about that one but you're right. Okay, I'm going to push an update to the CI scripts as well then :) |
This also updates the standalone-example's Cargo file to ensure it won't be accidentally published.
Well now you broke everything 😆. |
I feared so. I'm about to try and unbreak it. |
I'm on it as well, I think |
The tests succeed for me locally but I'm running Redis locally as well |
I think it would be easier to just skip the test on CI than to add an extra dependency there. At least that's easy to configure. Maybe you can add the CI configuration with in a separate PR? I really like to keep everything else lightweight as possible. |
I guess the host mapping is wrong, which makes sense. But changing that would mean local tests failing when you don't have a mapping in your hosts file. Just made a push with (hopefully) a cirrus skip test. Not sure I've got the syntax right though |
Apparently not |
…nal_container to cirrus" This reverts commit e6a1904.
Let's try a literal environment flag in tests then ^^ |
It seems your rust foo is doing the trick |
No real changes, just added serde_urlencoded to the db-example sub-project
I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.