Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation error #21

Closed
wants to merge 1 commit into from

Conversation

subhojit777
Copy link

This changes/fixes/improves #15;

@HeroicKatora
Copy link
Owner

HeroicKatora commented Nov 13, 2018

This seems to be fine for me, does the compilation error happen on nightly? If not, which compiler version and environment are we talking about?

@subhojit777
Copy link
Author

rustc 1.30.1 (1433507eb 2018-11-07)

@subhojit777
Copy link
Author

I am working on the dev-v0.4.0 branch.

@HeroicKatora
Copy link
Owner

HeroicKatora commented Nov 13, 2018

Weird, I can't replicate it with exactly the same compiler version.

Maybe your work is based on some intermediate commit in a longer commit series. Can you try to base your work on the tag v0.4.0-preview.0? Note that the development branch is expected to change a lot, including breaking changes and non-compiling versions but only all tagged versions (aka. those published to <crates.io>) should work correctly. Still, your patch seems to be based on commit e6211cb which I can compile fine.

I'm a bit puzzled to be honest.

Edit: it could still be useful to apply these patches but the scope-list may as well be included in the state of the actix app then. Or maybe even create a simple wrapper struct, whichever is clearer. The current version was more a proof of concept, it needs to be improved at some point.

@subhojit777
Copy link
Author

I was not able to compile with the 0.4.0-preview.0 version. There is a conflict with ring crate - #15 (comment)

@HeroicKatora
Copy link
Owner

Sorry that I never got around to this as it was a preview version and I could reproduce it. This should not happen in v0.4 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants