New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gender filter display #136
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng/virtualsupporttalks into gender_filter_display
changed: changed category logic to select correct catagory based on the name and not button type (since there are 3 possible categories and only two possible button types, the old logic doesn't work anymore)
…fined in another module
…ll havinf the same behavior (filtering just one tag, instead of more than one.
NoeliaEle
requested changes
Jan 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Francine, I added some comments regarding the code style, but still couldn't sit down to try fixing the filtering issue. Feel free to ignore it for now and tackle it all together, also when Markus provides feedback.
… the gender filter add genders, instead of exclude them
NoeliaEle
force-pushed
the
gender_filter_display
branch
from
January 11, 2023 20:01
7e03c43
to
da8f92d
Compare
HerrBertling
approved these changes
Feb 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request regarding the gender filter display. It is currently displaying a single gender. It might need some other changes, like add an "All", to display all genders.