Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gender filter display #136

Merged
merged 24 commits into from Feb 5, 2023
Merged

Gender filter display #136

merged 24 commits into from Feb 5, 2023

Conversation

Francine-Pepe
Copy link
Collaborator

Pull request regarding the gender filter display. It is currently displaying a single gender. It might need some other changes, like add an "All", to display all genders.

Copy link
Collaborator

@NoeliaEle NoeliaEle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Francine, I added some comments regarding the code style, but still couldn't sit down to try fixing the filtering issue. Feel free to ignore it for now and tackle it all together, also when Markus provides feedback.

app/components/SpeakingTimeContent.tsx Outdated Show resolved Hide resolved
@types/generated/contentful.d.ts Outdated Show resolved Hide resolved
app/components/CoachList.tsx Show resolved Hide resolved
app/components/SpeakingTimeContent.tsx Outdated Show resolved Hide resolved
@HerrBertling HerrBertling merged commit 973c683 into main Feb 5, 2023
@HerrBertling HerrBertling deleted the gender_filter_display branch February 5, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants