Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support next(false) in beforeRouteEnter #74

Closed
whitetrefoil opened this issue Jul 2, 2018 · 0 comments
Closed

Support next(false) in beforeRouteEnter #74

whitetrefoil opened this issue Jul 2, 2018 · 0 comments
Assignees
@HerringtonDarkholme

Comments

@whitetrefoil
Copy link
Contributor

So sorry I just realized the PR #72 may have problem, beforeRouteEnter seems also support next(false)...

I'm taking deep look at it and will file a new PR ASAP.
@HerringtonDarkholme HerringtonDarkholme changed the title PR #72 May Have Problem... Support next(false) in beforeRouteEnter Jul 2, 2018
@HerringtonDarkholme HerringtonDarkholme self-assigned this Jul 2, 2018
HerringtonDarkholme pushed a commit that referenced this issue Jul 4, 2018
@whitetrefoil @HerringtonDarkholme
[#74] Fix wrong typing caused in #72 (#75)
d634d60 
* A word in README looks like a typo

* Make router lifecycle easier to use

* Export NextFunc

* Add an example of vue-router lifecycle

* Support `vm` in beforeRouteEnter lifecycle next function

* Support `vm` in beforeRouteLeave lifecycle next function

* Update README for more vue-router lifecycles

* Update README for better format

* Fix NextFuncVm boundary issue

* Merge beforeRouteUpdate & beforeRouteLeave

* Remove unnecessary

* Update README

* Optimize README

* Refer to vue-router's NavigationGuard definition

* Remove `NextFuncBool` from previous PR in README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HerringtonDarkholme HerringtonDarkholme

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whitetrefoil @HerringtonDarkholme