Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I hope it's faster. #6

Open
tingfeng-key opened this issue Jul 6, 2019 · 2 comments
Open

I hope it's faster. #6

tingfeng-key opened this issue Jul 6, 2019 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@tingfeng-key
Copy link

I hope it's faster for next_frame
@Herschel Herschel added the help wanted Extra attention is needed label Jul 8, 2019
@Herschel
Copy link
Owner

Herschel commented Jul 8, 2019 •
edited
Loading

First step would be to add test vectors + benchmark vectors (#1 and #2). Then we could find bottlenecks and test improvements to the specific algorithms. Best would be to port some of the very optimized algorithms from minimp3. Most of the current code are the straight-forward algorithms I converted from PDMP3, etc.

Then, we could investigate using SIMD/threads to improve performance (packed_simd and rayon?). However, I don't believe these work with wasm32 currently, which is my main target.

@tingfeng-key
Copy link
Author

Yes, minimp3 is fast. I'm using it now, but I don't know C and C++. I can't help you with this improvement. I'm sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Herschel @tingfeng-key