Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

29 scan directory recursive fix #49

Merged

Conversation

Valdocco
Copy link
Contributor

We have to check the case when the function returns false if directory is empty.
Otherwise error will be thrown: "array_merge(): Argument #2 is not an array"

@camspiers
Copy link
Contributor

Probably best to check if is is_array as well

@h4cc
Copy link
Collaborator

h4cc commented Oct 1, 2015

Using !== false will work, because scanDirectory() will either return false || array().

But i think @camspiers hint with white-testing for array may be more fitting.

@Valdocco
Copy link
Contributor Author

Valdocco commented Oct 1, 2015

Ok sir, it's true, is_array check is more strict and better therefore

@camspiers
Copy link
Contributor

Looks good to me. Thanks @Valdocco

@Valdocco Valdocco changed the title 29 fix scan directory recursive fix 29 scan directory recursive fix Oct 1, 2015
@h4cc
Copy link
Collaborator

h4cc commented Oct 1, 2015

@Herzult Merge plz ❓

@Valdocco
Copy link
Contributor Author

Valdocco commented Oct 2, 2015

What's about merge?

Herzult added a commit that referenced this pull request Oct 2, 2015
@Herzult Herzult merged commit 13eec7e into Herzult:master Oct 2, 2015
@Herzult
Copy link
Owner

Herzult commented Oct 2, 2015

Thank you guys!

@fabien-somnier
Copy link

@Herzult do you think you will soon create a new release with this bugfix ? tx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants