Additional property that allows positioning of image relative to text #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ive to one another
|
Thanks for the pull request and the awesome work! This version of HMSegmentedControl is currently in maintenance mode, so I'm only merging bug-fix pull requests, not new features. Feel free to contribute to the brand new Swift version. |
|
I don't get it. It's such a useful feature. I would love to see it get merged. Also, there's a bug fix for text and image overlapping, which you've reverted. Any reason why ? |
|
this is really useful feature , hope to be merged soon |
|
Okay, let's merge this! I would be grateful if you update the branch to the latest version of master to be able to merge it. |
added 2 commits
August 31, 2017 10:51
# Conflicts: # HMSegmentedControl/HMSegmentedControl.m
|
Should be up to date now :) |
|
@lordzsolt awesome, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added imagePosition property. The image can be left, right, above, below or behind the text.
Both dynamic and fixed width is supported.