Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoding of 9-digits MSIN when MNC is 3 digits #103

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Conversation

linouxis9
Copy link
Member

Types of changes

  • All new and existing tests passed.
  • I have read the CONTRIBUTING document.
  • Each of my commits messages include Signed-off-by: Author Name <authoremail@example.com> to accept the DCO.

Signed-off-by: Valentin <valentin@devling.xyz>
@linouxis9
Copy link
Member Author

Hi @rjaksa,

Could you test the fix?

Thanks a lot!

Cheers,
Valentin

@rjaksa
Copy link

rjaksa commented Mar 28, 2024

In tools.go...

The 9-digit MSINs look correct for both ueCfg and simConfig now (as shown when adding the "Debug 1" and "Debug 2" lines mentioned in the original issue description).

But simConfig.Gnbs[gnbIdGen(0)] is still NULL (i.e. output of "Debug 3" in the original bug report is still ), so PacketRusher crashes in tools.go due to a nil pointer dereference.

@linouxis9
Copy link
Member Author

linouxis9 commented Mar 28, 2024

@rjaksa
I'm not hitting the issue where a NULL is returned when using a 3-digits MNC / 9-digits msin, everything seems to work on my side.
I'll try to reproduce again.
Could you share the log of the crash?
Thanks a lot!

@linouxis9
Copy link
Member Author

Or maybe you are referring to this crash? #104

@linouxis9 linouxis9 merged commit d819a33 into main Apr 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] PacketRusher crashes when UE has an MNC with 3 digits
2 participants