-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nettest_omni: Remove duplicate variable definitions #46
base: master
Are you sure you want to change the base?
Conversation
These defines are already defined in nettest_bsd.c and exported by nettest_bsd.h this should fix build with -fno-common Signed-off-by: Khem Raj <raj.khem@gmail.com>
patch HewlettPackard/netperf#46 to the existing netperf Signed-off-by: Yanan Fu <yfu@redhat.com>
Would this also solve for "Unable to compile on Fedora 32" #42? |
i think so |
When run 'make' command to compile netperf, meet following error: gcc -o netperf netperf.o netlib.o netsh.o nettest_bsd.o nettest_dlpi.o nettest_unix.o nettest_xti.o nettest_sctp.o nettest_sdp.o nettest_omni.o net_uuid.o dscp.o netcpu_none.o netrt_none.o netdrv_none.o netslot_none.o netsys_none.o netsec_none.o -lm /usr/bin/ld: nettest_omni.o:(.bss+0x398): multiple definition of `loc_nodelay'; nettest_bsd.o:(.bss+0x20): first defined here /usr/bin/ld: nettest_omni.o:(.bss+0x39c): multiple definition of `rem_nodelay'; nettest_bsd.o:(.bss+0x24): first defined here /usr/bin/ld: nettest_omni.o:(.bss+0x3a0): multiple definition of `loc_sndavoid'; nettest_bsd.o:(.bss+0x30): first defined here /usr/bin/ld: nettest_omni.o:(.bss+0x3a4): multiple definition of `loc_rcvavoid'; nettest_bsd.o:(.bss+0x34): first defined here /usr/bin/ld: nettest_omni.o:(.bss+0x3a8): multiple definition of `rem_sndavoid'; nettest_bsd.o:(.bss+0x38): first defined here /usr/bin/ld: nettest_omni.o:(.bss+0x3ac): multiple definition of `rem_rcvavoid'; nettest_bsd.o:(.bss+0x3c): first defined here collect2: error: ld returned 1 exit status make[3]: *** [Makefile:443: netperf] Error 1 One patch [1] is to fix this issue. According to this patch to update netperf package. [1] HewlettPackard/netperf#46 Signed-off-by: lcheng <lcheng@redhat.com>
When run 'make' command to compile netperf, meet following error: gcc -o netperf netperf.o netlib.o netsh.o nettest_bsd.o nettest_dlpi.o nettest_unix.o nettest_xti.o nettest_sctp.o nettest_sdp.o nettest_omni.o net_uuid.o dscp.o netcpu_none.o netrt_none.o netdrv_none.o netslot_none.o netsys_none.o netsec_none.o -lm /usr/bin/ld: nettest_omni.o:(.bss+0x398): multiple definition of `loc_nodelay'; nettest_bsd.o:(.bss+0x20): first defined here /usr/bin/ld: nettest_omni.o:(.bss+0x39c): multiple definition of `rem_nodelay'; nettest_bsd.o:(.bss+0x24): first defined here /usr/bin/ld: nettest_omni.o:(.bss+0x3a0): multiple definition of `loc_sndavoid'; nettest_bsd.o:(.bss+0x30): first defined here /usr/bin/ld: nettest_omni.o:(.bss+0x3a4): multiple definition of `loc_rcvavoid'; nettest_bsd.o:(.bss+0x34): first defined here /usr/bin/ld: nettest_omni.o:(.bss+0x3a8): multiple definition of `rem_sndavoid'; nettest_bsd.o:(.bss+0x38): first defined here /usr/bin/ld: nettest_omni.o:(.bss+0x3ac): multiple definition of `rem_rcvavoid'; nettest_bsd.o:(.bss+0x3c): first defined here collect2: error: ld returned 1 exit status make[3]: *** [Makefile:443: netperf] Error 1 One patch [1] is to fix this issue. According to this patch to update netperf package. [1] HewlettPackard/netperf#46 Signed-off-by: lcheng <lcheng@redhat.com>
When run 'make' command to compile netperf, meet following error: gcc -o netperf netperf.o netlib.o netsh.o nettest_bsd.o nettest_dlpi.o nettest_unix.o nettest_xti.o nettest_sctp.o nettest_sdp.o nettest_omni.o net_uuid.o dscp.o netcpu_none.o netrt_none.o netdrv_none.o netslot_none.o netsys_none.o netsec_none.o -lm /usr/bin/ld: nettest_omni.o:(.bss+0x398): multiple definition of `loc_nodelay'; nettest_bsd.o:(.bss+0x20): first defined here /usr/bin/ld: nettest_omni.o:(.bss+0x39c): multiple definition of `rem_nodelay'; nettest_bsd.o:(.bss+0x24): first defined here /usr/bin/ld: nettest_omni.o:(.bss+0x3a0): multiple definition of `loc_sndavoid'; nettest_bsd.o:(.bss+0x30): first defined here /usr/bin/ld: nettest_omni.o:(.bss+0x3a4): multiple definition of `loc_rcvavoid'; nettest_bsd.o:(.bss+0x34): first defined here /usr/bin/ld: nettest_omni.o:(.bss+0x3a8): multiple definition of `rem_sndavoid'; nettest_bsd.o:(.bss+0x38): first defined here /usr/bin/ld: nettest_omni.o:(.bss+0x3ac): multiple definition of `rem_rcvavoid'; nettest_bsd.o:(.bss+0x3c): first defined here collect2: error: ld returned 1 exit status make[3]: *** [Makefile:443: netperf] Error 1 One patch [1] is to fix this issue. According to this patch to update netperf package. [1] HewlettPackard/netperf#46 Signed-off-by: lcheng <lcheng@redhat.com>
These defines are already defined in nettest_bsd.c and exported by nettest_bsd.h this should fix build with -fno-common Thanks to Khem Raj raj.khem@gmail.com Relates: HewlettPackard#46
These defines are already defined in nettest_bsd.c and exported by nettest_bsd.h this should fix build with -fno-common Thanks to Khem Raj raj.khem@gmail.com Relates: HewlettPackard#46 Signed-off-by: Tam Mach <sayboras@yahoo.com>
Pull from sayboras/netperf that has the multiple definitions fix (HewlettPackard/netperf#46). Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, tested this on ubi9 and was able to successfully build netperf. Without this patch it was unable to build.
Pull from sayboras/netperf that has the multiple definitions fix (HewlettPackard/netperf#46). Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
Pull from sayboras/netperf that has the multiple definitions fix (HewlettPackard/netperf#46). Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
@jtaleric Can you please merge this PR, with out this netperf build fails for all platform |
@kirbychris @GavinB-hpe sorry for the spam can anyone you (not sure if any one of active here if not can you please help us to reach out to right person ) please help us to merge this PR we are kind of stuck here as we did not get maintainer list in repo |
I don't have that authority 😢 |
@HewlettPackard @ChrisLynchHPE can you please help here |
I do not own this repository and have no knowledge on the code. I am unaware who even maintains this repository. |
These defines are already defined in nettest_bsd.c and exported by
nettest_bsd.h this should fix build with -fno-common
Signed-off-by: Khem Raj raj.khem@gmail.com