Feature/5298: Move uplinkset type and LIG/LI checks to init (no need to redo them) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stenioaraujo
force-pushed
the
feature/5298
branch
from
573ed22
to
f12d26b
Compare
stenioaraujo
changed the title
stenioaraujo
force-pushed
the
feature/5298
branch
from
f12d26b
to
3ff40fc
Compare
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
==========================================
- Coverage 71.78% 70.92% -0.86%
==========================================
Files 13 13
Lines 971 970 -1
==========================================
- Hits 697 688 -9
- Misses 274 282 +8
Continue to review full report at Codecov.
|
hugonicodemos
requested changes
Feb 7, 2018
| @@ -38,6 +38,12 @@ def __init__(self): | |||
| CONF.oneview.uplinkset_mappings) | |||
| self.flat_net_mappings = common.load_conf_option_to_dict( | |||
| CONF.oneview.flat_net_mappings) | |||
|
|
|||
| common.check_uplinkset_types_constraint( | |||
There was a problem hiding this comment.
move those checks to initialize.
ricardoas
requested changes
Feb 7, 2018
| @@ -38,6 +38,12 @@ def __init__(self): | |||
| CONF.oneview.uplinkset_mappings) | |||
| self.flat_net_mappings = common.load_conf_option_to_dict( | |||
| CONF.oneview.flat_net_mappings) | |||
|
|
|||
| common.check_uplinkset_types_constraint( | |||
stenioaraujo
force-pushed
the
feature/5298
branch
2 times, most recently
from
548de85
to
6f7a8cb
Compare
hugonicodemos
approved these changes
Feb 8, 2018
SauloAislan
approved these changes
Feb 14, 2018
ricardoas
approved these changes
Feb 15, 2018
GustavoDinizMonteiro
approved these changes
Feb 15, 2018
stenioaraujo
force-pushed
the
feature/5298
branch
from
6f7a8cb
to
5541699
Compare
Move `check_uplinkset_types_constraint` and `check_unique_lig_per_provider_constraint` from the Synchronization periodic start to the Driver Initialization. Therefore, those checks are executed only once.
stenioaraujo
force-pushed
the
feature/5298
branch
2 times, most recently
from
dbea007
to
43df9ac
Compare
stenioaraujo
force-pushed
the
feature/5298
branch
from
43df9ac
to
3a15b82
Compare
ricardoas
approved these changes
Feb 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.