Merge branch 'master' into I624

HewlettPackard · Feb 8, 2021 · a04be13 · a04be13
2 parents 9f97cdf + 76099b7
commit a04be13
Show file tree

Hide file tree

Showing 39 changed files with 856 additions and 358 deletions.
diff --git a/.coveragerc b/.coveragerc
@@ -2,4 +2,4 @@
 
 exclude_lines =
     if __name__ == .__main__.:
-    except ImportError:
+    except ImportError:
diff --git a/.gitattributes b/.gitattributes
@@ -1,3 +1,3 @@
 *.py text eol=lf
 *.sh text eol=lf
-*.yml text eol=lf
+*.yml text eol=lf
diff --git a/.github/workflows/dockerimage.yml b/.github/workflows/dockerimage.yml
@@ -14,10 +14,10 @@ jobs:
       - uses: actions/checkout@v2
         name: Check out code
       - run: |
-         echo ::set-env name=RELEASE_VERSION::$(echo ${GITHUB_REF:10})
+         echo "GITHUB_REF=${GITHUB_REF:10}" >> $GITHUB_ENV
       - name: Login to Docker Hub
         run: echo ${{ secrets.DOCKER_PASSWORD }} | docker login -u ${{ secrets.DOCKER_USERNAME }} --password-stdin
       - name: Build the tagged Docker image
-        run: docker build . --file Dockerfile --tag hewlettpackardenterprise/hpe-oneview-sdk-for-ansible:${{ env.RELEASE_VERSION }}-OV5.5
+        run: docker build . --file Dockerfile --tag hewlettpackardenterprise/hpe-oneview-sdk-for-ansible:${{ env.GITHUB_REF }}-OV5.6
       - name: Push the tagged Docker image
-        run: docker push hewlettpackardenterprise/hpe-oneview-sdk-for-ansible:${{ env.RELEASE_VERSION }}-OV5.5
+        run: docker push hewlettpackardenterprise/hpe-oneview-sdk-for-ansible:${{ env.GITHUB_REF }}-OV5.6
diff --git a/.gitignore b/.gitignore
@@ -8,4 +8,4 @@ examples/vars/config.yml
 *~
 examples/vars/os_attributes.yaml
 **/.coverage
-htmlcov
+htmlcov
diff --git a/.travis.yml b/.travis.yml
@@ -1,5 +1,5 @@
 ###
-# Copyright (2016-2017) Hewlett Packard Enterprise Development LP
+# Copyright (2016-2021) Hewlett Packard Enterprise Development LP
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # You may not use this file except in compliance with the License.

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,7 +1,20 @@
 # Ansible Modules for HPE OneView Change Log
 
-## v5.9.1(unreleased)
-This release extends the planned support of the modules to OneView REST API version 2200 (OneView v5.5) and ImageStreamer REST API version 2000 (I3S v5.4)
+## v5.10.0(unreleased)
+This release extends the planned support of the modules to OneView REST API version 2400 (OneView v5.6).
+
+#### Major changes
+1. Achieved idempotency for below resources.
+   - Logical Interconnect Group
+   - Scope
+   - Server Profile
+   - Server Profile Template
+
+2. Added support for 4 new endpoints in oneview_logical_interconnect and oneview_logical_interconnect_facts resource.
+   - POST /rest/logical-interconnects/bulk-inconsistency-validation
+   - GET /rest/logical-interconnects/{id}/igmpSettings
+   - PUT /rest/logical-interconnects/{id}/igmpSettings
+   - PUT /rest/logical-interconnects/{id}/portFlapSettings
 
 #### Bug fixes & Enhancements
 - [#597] (https://github.com/HewlettPackard/oneview-ansible/issues/597) Rack rename do not work.
@@ -12,15 +25,83 @@ This release extends the planned support of the modules to OneView REST API vers
 - [#612] (https://github.com/HewlettPackard/oneview-ansible/issues/612) FC network bandwidth
 - [#614] (https://github.com/HewlettPackard/oneview-ansible/issues/614) Typo in oneview_server_profile_template_with_resource_name.yml
 - [#620] (https://github.com/HewlettPackard/oneview-ansible/issues/620) git installed ansible oneview container image.
+- [#622] (https://github.com/HewlettPackard/oneview-ansible/issues/622) Updating LIG with network set uri with mentioning networkset names.
 - [#624] (https://github.com/HewlettPackard/oneview-ansible/issues/624) Assign static MAC address from pool ID in SP template creation.
 
+### Modules supported in this release
+- oneview_alert_facts
+- oneview_appliance_device_read_community
+- oneview_appliance_device_read_community_facts
+- oneview_appliance_time_and_locale_configuration
+- oneview_appliance_time_and_locale_configuration_facts
+- oneview_certificates_server
+- oneview_certificates_server_facts
+- oneview_connection_template
+- oneview_connection_template_facts
+- oneview_enclosure
+- oneview_enclosure_facts
+- oneview_enclosure_group
+- oneview_enclosure_group_facts
+- oneview_ethernet_network
+- oneview_ethernet_network_facts
+- oneview_fc_network
+- oneview_fc_network_facts
+- oneview_fcoe_network
+- oneview_fcoe_network_facts
+- oneview_hypervisor_manager
+- oneview_hypervisor_manager_facts
+- oneview_hypervisor_cluster_profile
+- oneview_hypervisor_cluster_profile_facts
+- oneview_interconnect
+- oneview_interconnect_facts
+- oneview_interconnect_type_facts
+- oneview_interconnect_link_topology_facts
+- oneview_internal_link_set_facts
+- oneview_logical_downlink_facts
+- oneview_logical_enclosures
+- oneview_logical_enclosures_facts
+- oneview_logical_interconnect
+- oneview_logical_interconnect_facts
+- oneview_logical_interconnect_group
+- oneview_logical_interconnect_group_facts
+- oneview_login_detail_facts
+- oneview_network_set
+- oneview_network_set_facts
+- oneview_os_deployment_plan_facts
+- oneview_server_hardware
+- oneview_server_hardware_facts
+- oneview_server_hardware_type
+- oneview_server_hardware_type_facts
+- oneview_scope
+- oneview_scope_facts
+- oneview_server_profile
+- oneview_server_profile_facts
+- oneview_server_profile_template
+- oneview_server_profile_template_facts
+- oneview_storage_pool
+- oneview_storage_pool_facts
+- oneview_storage_system
+- oneview_storage_system_facts
+- oneview_storage_volume
+- oneview_storage_volume_facts
+- oneview_storage_volume_attachment
+- oneview_storage_volume_attachment_facts
+- oneview_storage_volume_template
+- oneview_storage_volume_template_facts
+- oneview_switch_type_facts
+- oneview_task_facts
+- oneview_unmanaged_device
+- oneview_unmanaged_device_facts
+- oneview_uplink_set
+- oneview_uplink_set_facts
+- oneview_version_facts
 
 ## v5.9.0
 This release extends the planned support of the modules to OneView REST API version 2200 (OneView v5.5) and ImageStreamer REST API version 2000 (I3S v5.4)
 
 #### Bug fixes & Enhancements
 - [#581] (https://github.com/HewlettPackard/oneview-ansible/issues/581) Updating single uplinkSet in LIG removes other uplinkSet.
-- [#582] (https://github.com/HewlettPackard/oneview-ansible/issues/582) description field is empty after server profile creation
+- [#582] (https://github.com/HewlettPackard/oneview-ansible/issues/582) description field is empty after server profile creation.
 
 ### Modules supported in this release
 - image_streamer_artifact_bundle

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -60,8 +60,7 @@ name and email address (git commit -s will do this for you):
 
     Signed-off-by: Jane Example <jane@example.com>
 
-For legal reasons, no anonymous or pseudonymous contributions are
-accepted.
+For legal reasons, no anonymous or pseudonymous contributions are accepted.
 
 ## Submitting Code Pull Requests
 

diff --git a/Dockerfile b/Dockerfile
@@ -32,6 +32,7 @@ RUN pip install -r test_requirements.txt
 ENV ANSIBLE_LIBRARY=/root/oneview-ansible/library
 ENV ANSIBLE_MODULE_UTILS=/root/oneview-ansible/library/module_utils/
 
+
 # Clean and remove not required packages
 RUN DEBIAN_FRONTEND=noninteractive \
     apt-get autoremove -y && \

diff --git a/LICENSE b/LICENSE
@@ -186,7 +186,7 @@ file or class name and description of purpose be included on the
 same "printed page" as the copyright notice for easier
 identification within third-party archives.
 
-Copyright 2015-2016 Hewlett Packard Enterprise
+Copyright 2015-2021 Hewlett Packard Enterprise
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

diff --git a/README.md b/README.md
@@ -2,9 +2,10 @@
 
 ## Build Status 
 
-| 5.50 Branch   | 5.40 Branch   | 5.30 Branch   | 5.20 Branch   | 5.00 Branch   |
+OV Version | 5.60 | 5.50 | 5.40 | 5.30 |
 | ------------- |:-------------:| -------------:| -------------:| -------------:|
-| ![Build status](https://ci.appveyor.com/api/projects/status/u84505l6syp70013?svg=true)| ![Build status](https://ci.appveyor.com/api/projects/status/u84505l6syp70013?svg=true)| ![Build status](https://ci.appveyor.com/api/projects/status/u84505l6syp70013?svg=true)| ![Build status](https://ci.appveyor.com/api/projects/status/u84505l6syp70013?svg=true)| ![Build status](https://ci.appveyor.com/api/projects/status/u84505l6syp70013?svg=true)
+SDK Version/Tag | [Master](https://github.com/HewlettPackard/oneview-ansible/tree/master) | [v5.9.0](https://github.com/HewlettPackard/oneview-ansible/releases/tag/v5.9.0) | [v5.8.0](https://github.com/HewlettPackard/oneview-ansible/releases/tag/v5.8.0) | [v5.7.0](https://github.com/HewlettPackard/oneview-ansible/releases/tag/v5.7.0) |
+Build Status | ![Build status](https://ci.appveyor.com/api/projects/status/u84505l6syp70013?svg=true)| ![Build status](https://ci.appveyor.com/api/projects/status/u84505l6syp70013?svg=true)| ![Build status](https://ci.appveyor.com/api/projects/status/u84505l6syp70013?svg=true)| ![Build status](https://ci.appveyor.com/api/projects/status/u84505l6syp70013?svg=true)|
 
 
 ## Introduction
@@ -18,7 +19,7 @@ Each OneView resource operation is exposed through an Ansible module. Specific m
 
 ## What's New
 
-HPE OneView Ansible library extends support of the SDK to OneView REST API version 2200 (OneView v5.50)
+HPE OneView Ansible library extends support of the SDK to OneView REST API version 2400 (OneView v5.60)
 
 Please refer to [notes](https://github.com/HewlettPackard/oneview-ansible/blob/master/CHANGELOG.md) for more information on the changes , features supported and issues fixed in this version
 
@@ -62,12 +63,12 @@ The containerized version of the oneview-ansible modules is available in the [Do
 
 #### Download and store a local copy of  hpe-oneview-sdk-for-ansible and use it as a Docker image.
 ```bash
-$ docker pull hewlettpackardenterprise/hpe-oneview-sdk-for-ansible:v5.9.0-OV5.5
+$ docker pull hewlettpackardenterprise/hpe-oneview-sdk-for-ansible:v5.10.0-OV5.6
 ```
 
 #### Run docker command which in turn will create a sh session where SDK user can create files, issue commands and execute playbooks
 ```bash
-$ docker run -it hewlettpackardenterprise/hpe-oneview-sdk-for-ansible:v5.9.0-OV5.5 /bin/sh
+$ docker run -it hewlettpackardenterprise/hpe-oneview-sdk-for-ansible:v5.10.0-OV5.6 /bin/sh
 ```
 
 There is also a [how-to guide](https://github.com/HewlettPackard/oneview-ansible-samples/blob/master/oneview-ansible-in-container/oneview-ansible-in-container.md) with instructions on how to use the container without creating a sh session.
@@ -85,7 +86,7 @@ To use the Ansible OneView modules, connection properties for accessing the OneV
     "authLoginDomain": "",
     "password": "secret123"
   },
-  "api_version": 2200
+  "api_version": 2400
 }
 ```
 
@@ -146,7 +147,7 @@ This option allows the parameters `hostname`, `username`, `password`, `api_versi
     hostname: 172.16.101.48
     username: administrator
     password: my_password
-    api_version: 2200
+    api_version: 2400
     state: present
     data:
       name: "{{ network_name }}"
@@ -173,7 +174,7 @@ Ansible Vault feature may be leveraged for storing the credential of the user in
 	    ```yaml
 	    # Required
 	    ip: 172.168.1.1
-	    api_version:2200
+	    api_version:2400
 	    username: Administrator
 	    password: !vault |
           $ANSIBLE_VAULT;1.1;AES256
@@ -217,17 +218,17 @@ Note: Most of the examples provided in this repository uses OneView Credentials
 
 ### Setting OneView API Version
 
-The Ansible modules for HPE OneView support the API endpoints for HPE OneView 4.00, 4.10, 4.20, 5.00, 5.20, 5.30, 5.40, 5.50 <br/>
+The Ansible modules for HPE OneView support the API endpoints for HPE OneView 4.00, 4.10, 4.20, 5.00, 5.20, 5.30, 5.40, 5.50, 5.60 <br/>
 The current `default` HPE OneView version will pick the OneView appliance version.
 
 To use a different API, you must set the API version together with your credentials, either using the JSON configuration:
 ```bash
-"api_version": 2200
+"api_version": 2400
 ```
 
 OR using the Environment variable: 
 ```bash
-export ONEVIEWSDK_API_VERSION='2200'
+export ONEVIEWSDK_API_VERSION='2400'
 ```
 
 If this property is not specified, it will fall back to the default value.

diff --git a/TESTING.md b/TESTING.md
@@ -32,7 +32,7 @@ All unit tests are inside the test folder. You can execute them manually by usin
 All code must have associated tests, be it the already implemented or newly submitted, and this section covers what tests need to be implemented.
 
 ### Implementing the unit tests
-The unit tests are required for each new resource, bug fix, or enhancement. They must cover what is being submitted and if necessary use the `mock` to mock OneView appliance communication.
+The unit tests are required for each new resource, bug fix or enhancement. They must cover what is being submitted and if necessary use the `mock` to mock OneView appliance communication.
 
 ### Acceptance criteria
 The necessary amount of testing is defined by who is implementing and by who is reviewing and accepting the code, however, the unit test coverage is inspected by the coveralls and it won't allow it to drop.
diff --git a/Update-UserScript.py b/Update-UserScript.py
@@ -1,5 +1,5 @@
 ##############################################################################
-# (C) Copyright [2020] Hewlett Packard Enterprise Development LP
+# (C) Copyright [2021] Hewlett Packard Enterprise Development LP
 #
 # File Name: Update-UserScript.py
 # VERSION 1.0

diff --git a/build-doc/generate_documentation.yml b/build-doc/generate_documentation.yml
@@ -1,5 +1,5 @@
 ###
-# Copyright (2016-2017) Hewlett Packard Enterprise Development LP
+# Copyright (2016-2021) Hewlett Packard Enterprise Development LP
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # You may not use this file except in compliance with the License.

diff --git a/build-doc/oneview_ansible_documentation.j2 b/build-doc/oneview_ansible_documentation.j2
@@ -1,5 +1,5 @@
 {###
-# Copyright (2016-2017) Hewlett Packard Enterprise Development LP
+# Copyright (2016-2021) Hewlett Packard Enterprise Development LP
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # You may not use this file except in compliance with the License.

diff --git a/build.sh b/build.sh
@@ -1,7 +1,7 @@
 #!/bin/bash
 # -*- coding: utf-8 -*-
 ###
-# Copyright (2016-2017) Hewlett Packard Enterprise Development LP
+# Copyright (2016-2021) Hewlett Packard Enterprise Development LP
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # You may not use this file except in compliance with the License.