Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hypervisor managers resource for API 800, 1000 and 1200 #493

Merged
merged 2 commits into from
Apr 27, 2020

Conversation

VenkateshRavula
Copy link
Collaborator

@VenkateshRavula VenkateshRavula commented Apr 23, 2020

Description

Added hypervisor managers resource for API 800, 1000 and 1200

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass. ($ ./build.sh).
  • New functionality has been documented in the README if applicable.
    • New functionality has been thoroughly documented in the examples (please include helpful comments).

- Provides an interface to manage Hypervisor Managers resources. Can create, update, and delete.
version_added: "2.4"
requirements:
- "python >= 2.7.9"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update the supported python version as 3 as python 2 versions got deprecated.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

- Retrieve the facts about one or more of the Hypervisor Managers from OneView.
version_added: "2.4"
requirements:
- "python >= 2.7.9"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update python version

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

requirements.txt Outdated
@@ -1,3 +1,3 @@
ansible
hpICsp
hpOneView==5.0.0
hpOneView==5.1.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

safe to update when we have support for all the resources upgraded in the new Python SDK release. I think we should update this when we release the new library version.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

@sijeesh sijeesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VenkateshRavula VenkateshRavula merged commit 6e3dd3e into master Apr 27, 2020
@VenkateshRavula VenkateshRavula deleted the Hypervisor_managers branch April 27, 2020 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants