Added hypervisor cluster profile resource for API 800, 1000 and 1200 #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VenkateshRavula
requested review from
sijeesh,
AnushaY1916,
soodpr,
chebroluharika and
nabhajit-ray
AnushaY1916
reviewed
Apr 30, 2020
| ''' | ||
|
|
||
| RETURN = ''' | ||
| hypervisor_manager: |
There was a problem hiding this comment.
It should be Hyper cluster profile, not hypervisor manager.
soodpr
reviewed
Apr 30, 2020
| version_added: "2.4" | ||
| requirements: | ||
| - "python >= 3.4.2" | ||
| - "hpOneView >= 5.1.0" |
There was a problem hiding this comment.
hpOneView version should be 5.1.1
There was a problem hiding this comment.
actually i just noticed that python sdk patch is for your other PR#494. Please modify there.
soodpr
approved these changes
Apr 30, 2020
jyothisgm
reviewed
Apr 30, 2020
| #!/usr/bin/python | ||
| # -*- coding: utf-8 -*- | ||
| ### | ||
| # Copyright (2016-2019) Hewlett Packard Enterprise Development LP |
There was a problem hiding this comment.
change the copyright to 2020
jyothisgm
reviewed
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added hypervisor cluster profile resource for API 800, 1000 and 1200
Issues Resolved
Check List
$ ./build.sh).