Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #341 #529

Merged
merged 5 commits into from
Jun 15, 2020
Merged

Fix for #341 #529

merged 5 commits into from
Jun 15, 2020

Conversation

chebroluharika
Copy link
Collaborator

@chebroluharika chebroluharika commented Jun 11, 2020

Description

Fixes in LIG example file

Issues Resolved

#341

Check List

  • New functionality includes testing.
    • All tests pass. ($ ./build.sh).
  • New functionality has been documented in the README if applicable.
    • New functionality has been thoroughly documented in the examples (please include helpful comments).

@chebroluharika chebroluharika changed the title Fixes in LIG example file Fix for #341 Jun 11, 2020
type: "Enclosure"
- relativeValue: 6
type: "Bay"
permittedInterconnectTypeUri: "/rest/interconnect-types/c16e12d7-06ea-4bbf-ad22-f46d78540dcc"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to provide permittedInterconnectTypeName instead of permittedInterconnectTypeUri in example and check if it works. Also add a comment for this playbook mentioning for which enclosure setup will this yaml works. (This playbook works for synergy 3 enclosure setup)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

@nabhajit-ray nabhajit-ray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chebroluharika chebroluharika merged commit 43d4a89 into master Jun 15, 2020
@chebroluharika chebroluharika deleted the Fix341 branch June 15, 2020 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logical_Interconnect_Group Module , idempotency , Uplinksets for Synergy
4 participants