Merge pull request #367 from HewlettPackard/volume_fix

Adding query parameter support

CHANGELOG.md

@@ -1,3 +1,11 @@
+## v5.6.1(Unreleased)
+
+#### Notes
+This release fixes few bugs listed below
+
+#### Bug fixes & Enhancements
+- [#366](https://github.com/HewlettPackard/oneview-sdk-ruby/issues/366) Query parameters not working for get_attachable_volumes endpoint
+
 ## v5.6.0
 
 #### Notes

examples/shared_samples/volume.rb

@@ -150,7 +150,10 @@
 puts "\nSnapshot removed successfully!"
 
 puts "\nGetting the attachable volumes managed by the appliance"
-attachables = volume_class.get_attachable_volumes(@client)
+query = {
+  connections: '<Your parameters here>'
+}
+attachables = volume_class.get_attachable_volumes(@client, query)
 puts "\nAttachable volumes found: #{attachables}"
 
 puts "\nGetting the list of extra managed storage volume paths"

lib/oneview-sdk/resource/api200/volume.rb

@@ -147,8 +147,9 @@ def get_snapshots
       # Gets all the attachable volumes managed by the appliance
       # @param [OneviewSDK::Client] client The client object for the OneView appliance
       # @return [Array<OneviewSDK::Volume>] Array of volumes
-      def self.get_attachable_volumes(client)
-        uri = "#{BASE_URI}/attachable-volumes"
+      def self.get_attachable_volumes(client, query = nil)
+        query_uri = build_query(query) if query
+        uri = "#{BASE_URI}/attachable-volumes#{query_uri}"
         find_by(client, {}, uri)
       end
 

spec/unit/resource/api200/volume_spec.rb

@@ -205,8 +205,10 @@
       it 'returns an array of available volumes' do
         volumes = [@item]
         allow_any_instance_of(OneviewSDK::Client).to receive(:response_handler).and_return('members' => volumes)
-        expect(@client_200).to receive(:rest_get).with('/rest/storage-volumes/attachable-volumes', {})
-        items = OneviewSDK::Volume.get_attachable_volumes(@client_200)
+        allow(@client_200).to receive(:build_query)
+          .with(@client_200, { 'sort' => 'name:ascending' }, described_class::BASE_URI, {}).and_return('?sort=name:ascending')
+        expect(@client_200).to receive(:rest_get).with('/rest/storage-volumes/attachable-volumes?sort=name:ascending', {})
+        items = OneviewSDK::Volume.get_attachable_volumes(@client_200, 'sort' => 'name:ascending')
         expect(items.class).to eq(Array)
         expect(items.size).to eq(1)
         expect(items.first['name']).to eq('volume_name')