incorported review comments

HewlettPackard · May 26, 2020 · b0b3bca · b0b3bca
1 parent 5152cc2
commit b0b3bca
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/examples/shared_samples/hypervisor_cluster_profile.rb b/examples/shared_samples/hypervisor_cluster_profile.rb
@@ -79,7 +79,8 @@
 puts "\nCompliance preview details are :\n#{cp}\n"
 
 # Deletes the created hypervisor cluster profile
-# Delete method accepts 2 optional arguments - soft_delete(boolean) and force(boolean)
-# The default values for both the arguments is "false"
-hcp.delete(true, true)
+# Delete method accepts 2 arguments - soft_delete(boolean) and force(boolean) which are optional till API1200
+# soft_delete has become mandatory argument in API1600 and force is still optional
+# The default values for the arguments is "false"
+hcp.delete(soft_delete = true, force = true)
 puts "\nSuccesfully deleted the cluster profile"
diff --git a/lib/oneview-sdk/resource/api1600/c7000/hypervisor_cluster_profile.rb b/lib/oneview-sdk/resource/api1600/c7000/hypervisor_cluster_profile.rb
@@ -17,7 +17,7 @@ module C7000
       # Hypervisor cluster profile resource implementation for API1600 C7000
       class HypervisorClusterProfile < OneviewSDK::API1200::C7000::HypervisorClusterProfile
 
-        # Both softDelete and force are optional arguments but from API1600 softDelete is made mandatory argument
+        # softDelete is mandatory argument in API1600
         def delete(soft_delete = false, force = false)
           ensure_client && ensure_uri
           uri = @data['uri']

diff --git a/spec/unit/resource/api1600/synergy/hypervisor_cluster_profile_spec.rb b/spec/unit/resource/api1600/synergy/hypervisor_cluster_profile_spec.rb
@@ -14,6 +14,7 @@
 RSpec.describe OneviewSDK::API1600::Synergy::HypervisorClusterProfile do
   include_context 'shared context'
 
+  # it inherit latest changes from API1600 C7000 lib file
   it 'inherits from OneviewSDK::API1600::C7000::HypervisorClusterProfile' do
     expect(described_class).to be < OneviewSDK::API1600::C7000::HypervisorClusterProfile
   end