Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_default_settings in API200 is currently an instance method, but it should be a class method #132

Closed
fgbulsoni opened this issue Jan 19, 2017 · 0 comments
Closed

get_default_settings in API200 is currently an instance method, but it should be a class method #132

fgbulsoni opened this issue Jan 19, 2017 · 0 comments
Assignees
@ricardogpsf
Labels
API200 breaking_change bug/bug-fix unexpected_behavior

Comments

@fgbulsoni
Copy link
Contributor

fgbulsoni commented Jan 19, 2017 •
edited
Loading

Scenario/Intent

Use the get_default_settings for API200 and 300 Logical Interconnect Group resource, either on Synergy or C7000, with the same syntax

Environment Details

  • OneView SDK Version: 3.1.0
  • OneView Appliance Version: 3.0
  • OneView Client API Version: 300
  • Ruby Version: 2.2.3
  • Platform: Windows

Steps to Reproduce

Use the methods, they are clear to use, but serve the same purpose even though they have different syntax.

Expected Result

The method gets defaults for something global, it should be a self method and could be implemented in api200 and just inherited by 300, with no need for repetition.

Actual Result

Currently there is an instance method on 200, and a self method on 300 synergy.
This was referenced Jan 20, 2017
Merged
Merged
@jsmartt jsmartt changed the title get_default_settings in API200 must be used is currently an instance method, when it should be a self method get_default_settings in API200 must be used is currently an instance method, when it should be a class method Jan 20, 2017
@jsmartt jsmartt changed the title get_default_settings in API200 must be used is currently an instance method, when it should be a class method get_default_settings in API200 is currently an instance method, but it should be a class method Jan 20, 2017
@ricardogpsf ricardogpsf self-assigned this Jan 23, 2017
ricardogpsf added a commit that referenced this issue Jan 23, 2017
@ricardogpsf
Fixes #132: get_default_settings in API200 is currently an instance
7069799 
method, but it should be a class method
@ricardogpsf ricardogpsf mentioned this issue Jan 23, 2017
Merged
5 tasks
ricardogpsf added a commit that referenced this issue Feb 2, 2017
@ricardogpsf
Merge pull request #140 from HewlettPackard/bugfix/issue_132_lig_get_…
d78ea55 
…default_settings

Fixes #132: get_default_settings in API200 is currently an instance method, but it should be a class method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricardogpsf ricardogpsf

Labels
API200 breaking_change bug/bug-fix unexpected_behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ricardogpsf @jsmartt @tmiotto @fgbulsoni