Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method add_uplink for LIG Uplinks Set does not work with Q ports nor integer ports #228

Closed
fgbulsoni opened this issue May 2, 2017 · 8 comments

Comments

@fgbulsoni
Copy link
Contributor

Scenario/Intent

When trying to use the lig_uplink_set method to set a Q port or even using the real integer value of the port, the following error is returned:
Could not evaluate: Port not supported: Q type not found

Environment Details

  • OneView SDK Version: 4.2.0

Steps to Reproduce

Run the add_uplink method using a Q or integer port.
i.e.:

OneviewSDK::LIGUplinkSet.new(@client, name: 'test').add_uplink(3, 'Q1:1')

Expected Result

The port specified is added to the uplink set

Actual Result

It returns errors when both an integer or a Q value port is used.

@fgbulsoni
Copy link
Contributor Author

This is related and reported by the issue HewlettPackard/oneview-puppet#148

@vranystepan
Copy link
Contributor

vranystepan commented May 2, 2017

Is this related to #216 ? I did not have time to test it yet but it should be possible to get correct port number from /rest/interconnect-types. But such functionality will require ICM model as the parameter ...

@fgbulsoni
Copy link
Contributor Author

@vranystepan Yep, definitely related. I was just looking into using the Q ports and Integer values though, hadn't crossed my mind using different frames.

@vranystepan
Copy link
Contributor

@fgbulsoni Multiple frames situation is pretty easy. Will try to figure out.
Anyway what do you mean with integer values? Do you mean the final relativeValue which can be directly placed to the Logical Interconnect Group data?

@fgbulsoni
Copy link
Contributor Author

fgbulsoni commented May 4, 2017

Do you mean the final relativeValue

Yep, I've been asked why it would not work if the correct relativevalue is used instead of a Q or D or whatever port, and it kind of made sense I guess.
Definitely not a must and something which may even not be used by users, but again, I've been asked about it.

@vranystepan
Copy link
Contributor

@fgbulsoni I've just put a few notes in the #216

@fgbulsoni
Copy link
Contributor Author

fgbulsoni commented May 5, 2017

@fgbulsoni I've just put a few notes in the #216

@vranystepan Looks like great work there, should indeed get rid of all these issues. Great job! 💯 ✨

@fgbulsoni
Copy link
Contributor Author

Closing since this was fixed by #230.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants