QSFP uplink & Integer ports support #230
Conversation
|
I will also check examples. perhaps it would be nice to put there an example. |
vranystepan
changed the title
|
I've extended example in API300:Synergy with the most complex scenario: multi-Frame config, multi-Frame Uplink Sets. It's quite standard Synergy configuration ;) |
|
Hey @vranystepan , is this ready to go on your end? |
|
@jsmartt yes it is. At least on my end 😄 |
| # @param [String] interconnect model name | ||
| # @param [Fixnum] enclosure number for multi-frame configurations | ||
| def add_uplink(bay, port, type = nil, enclosure_index = 1) | ||
| enclosure_index = !type.nil? && type.include?('Virtual Connect SE 16Gb FC Module') ? -1 : enclosure_index |
There was a problem hiding this comment.
!type.nil? can be replaced in this clause by type
| if type | ||
| fetch_relative_value_of(port, type) | ||
| else | ||
| port.to_s == port.to_i.to_s ? port : relative_value_of(port) |
There was a problem hiding this comment.
What's the point of port.to_s == port.to_i.to_s ?
There was a problem hiding this comment.
@tmiotto I've put it there to handle for example 67 and "67" I can change it to port.is_a?(Integer) and accept only Integers for the "Integer" ports. What do you think?
There was a problem hiding this comment.
Nope, it's fine as is! 😄
I would just add a comment explaining it, since it's not quite clear at first sight.
There was a problem hiding this comment.
@tmiotto cool. I've put there a comment. Also, such ports (67 or '67') will be always converted to Integer.
Description
This pull request contains fixes for #216 and #228. Now it is possible to create LIGs will all supported Interconnect Modules / Uplink ports. Legacy functionality for Ten-Gig (
X) and Downlink (D) ports has remained preserved. There is also a new functionality (requested in #228) which enables use of Integer ports (final relative value of uplink port).Issues Resolved
Check List
$ rake test).