Added scope helper methods to Switch resource #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmiotto
reviewed
Feb 21, 2017
|
|
||
| module OneviewSDK | ||
| module API300 | ||
| module C7000 | ||
| # Switch resource implementation | ||
| class Switch < OneviewSDK::API200::Switch | ||
| include OneviewSDK::API300::C7000::Scope::ScopeHelperMethods |
There was a problem hiding this comment.
I'm just concerned with the namespace this Mixin is inserted. Maybe this is not the best place to declare it, but I think it's not this PRs concern right now.
There was a problem hiding this comment.
ok. We could maintain it in our radar and open other issue after.
tmiotto
approved these changes
Feb 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added scope helper methods to Switch resource: add_scope, remove_scope and replace_scopes.
Issues Resolved
Fixes #146
Check List
$ rake test).