Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I3S enviroment variable token #187

Merged
merged 4 commits into from
Feb 22, 2017

Conversation

aalexmonteiro
Copy link
Contributor

Description

Implementation of improvements in i3s configuration, removing I3S_TOKEN, because is unncessary and updating the README and adjustig the creation of the i3s client to use ONEVIEWSDK_TOKEN when using the enviroment variable.

Issues Resolved

#183

Check List

  • New functionality includes testing.
    • All tests pass ($ rake test).
  • New functionality has been documented in the README if applicable.
    • New functionality has been thoroughly documented in the examples (please include helpful comments).
  • Changes are documented in the CHANGELOG.

@aalexmonteiro aalexmonteiro changed the title Enhancement/i3s env variable token I3S enviroment variable token Feb 21, 2017
Copy link
Collaborator

@jsmartt jsmartt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think eventually I'd like to see the I3S client be able to create a oneview client and take it's token automatically, effectively making the following work:

ENV['ONEVIEWSDK_URL'] = 'https://ov.example.com'
ENV['ONEVIEWSDK_USER'] = 'Admin'
ENV['ONEVIEWSDK_PASSWORD'] = 'secret123'
ENV['I3S_URL'] = 'https://i3s.example.com'

i3s_client = OneviewSDK::ImageStreamer::Client.new
# Note that I didn't have to set ENV['ONEVIEWSDK_TOKEN']

This will be helpful if we ever end up adding support for I3S endpoints in the cli.
But we can add that functionality in the future if we want.

@aalexmonteiro aalexmonteiro merged commit 00c3418 into master Feb 22, 2017
@aalexmonteiro aalexmonteiro deleted the enhancement/i3s_env_variable_token branch February 22, 2017 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants