-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed integration tests to perform end-to-end fully #261
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Just:
1- If the drive enclosure issue is something intermitent or related to your emulator, it is likely not necessary to raise an issue
2- The Storage System one does look like it needs further investigation, so it should be followed up on.
VolumeTemplate: [:StoragePool] | ||
VolumeTemplate: [:StoragePool], | ||
WebServerCertificate: [], | ||
ClientCertificate: [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, put in alphabetical order.
@@ -15,9 +15,10 @@ | |||
let(:item_attributes_2) { JSON.load(item_attributes.to_json) } | |||
|
|||
describe '#update', if: api_version <= 300 do | |||
it '#updating fc_network unmanaged ports' do | |||
xit '#updating fc_network unmanaged ports' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to describe why this test is not run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, this test should not be skipped. I'll fix it. Thanks. =)
Description
This PR is intented to fix integration tests self dependencies.
Some test will still failing but they are expected to fail (due the OV Appliance can not support some features, for example)
The tests were executed using OV 3.10.
All supported apis (200, 300 and 500) were tested.
You need install "License for HPE Synergy 8 Gb Fibre Channel upgrade" before the tests.
NOTE:
1- One test to Drive Enclosure is failing due a possible bug, I'll open a issue for it (failing to all apis that support this resource):
2 - One test to Storage System is failing due a possible bug, I'll open a issue for it (failing only to api300 Synergy):
Issues Resolved
#127
Check List
$ rake test
).