Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support to firmware driver for api800/1000/1200 #384

Merged
merged 6 commits into from
Feb 17, 2020
Merged

Adding support to firmware driver for api800/1000/1200 #384

merged 6 commits into from
Feb 17, 2020

Conversation

soodpr
Copy link
Member

@soodpr soodpr commented Feb 13, 2020

Description

Adding support to firmware driver for api800/1000/1200

Check List

  • New functionality includes testing.
    • All tests pass ($ rake test).
  • New functionality has been documented in the README if applicable.
    • New functionality has been thoroughly documented in the examples (please include helpful comments).
  • New endpoints supported are updated in the endpoints-support.md file.
  • Changes are documented in the CHANGELOG.

jyothisgm
jyothisgm approved these changes Feb 17, 2020
View reviewed changes
Copy link
Collaborator

@jyothisgm jyothisgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soodpr soodpr merged commit b20b81a into master Feb 17, 2020
@sijeesh sijeesh deleted the api1200/firmware_driver branch February 28, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madhav-bharadwaj madhav-bharadwaj madhav-bharadwaj approved these changes

@jyothisgm jyothisgm jyothisgm approved these changes

@AnushaY1916 AnushaY1916 Awaiting requested review from AnushaY1916

@sijeesh sijeesh Awaiting requested review from sijeesh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@soodpr @madhav-bharadwaj @jyothisgm