API1600 support for Interconnects #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please raise LI resource PR as well as Interconnect has dependency on LI. I will review this later |
AsisBagga
reviewed
May 26, 2020
| # api_version = 600 & variant = Synergy to OneviewSDK::API600::Synergy::Interconnect' | ||
| # - 200, 300, 500, 600, 800, 1000, 1200, 1600 | ||
| # Supoported Variants | ||
| # C7000, Synergy |
There was a problem hiding this comment.
Not sure why parameter details were removed. Need to add them.
| def initialize(client, params = {}, api_ver = nil) | ||
| @data ||= {} | ||
| # Default values | ||
| @data['type'] ||= 'InterconnectV7' |
There was a problem hiding this comment.
There is no interconnectV7, please remove the initialize method if same method exist in API1200.
| def initialize(client, params = {}, api_ver = nil) | ||
| @data ||= {} | ||
| # Default values | ||
| @data['type'] ||= 'InterconnectV7' |
| describe '#initialize' do | ||
| it 'should be initialize the instance with default values' do | ||
| item = described_class.new(@client_1600) | ||
| expect(item['type']).to eq('InterconnectV7') |
There was a problem hiding this comment.
please correct this as well
| describe '#initialize' do | ||
| it 'should be initialize the instance with default values' do | ||
| item = described_class.new(@client_1600) | ||
| expect(item['type']).to eq('InterconnectV7') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
API1600 support for Interconnects
Issues Resolved
NA
Check List
$ rake test).