Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding API1600 support for Ethernet/FC/FCoE network resources #412

Merged
merged 7 commits into from May 20, 2020
Merged

Adding API1600 support for Ethernet/FC/FCoE network resources #412

merged 7 commits into from May 20, 2020

Conversation

yuvirani
Copy link
Collaborator

@yuvirani yuvirani commented May 18, 2020 •
edited

Description

Adding API1600 support for Ethernet/FC/FCoE network resources

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass ($ rake test).
  • New functionality has been documented in the README if applicable.
    • New functionality has been thoroughly documented in the examples (please include helpful comments).
  • New endpoints supported are updated in the endpoints-support.md file.
  • Changes are documented in the CHANGELOG.

chebroluharika
chebroluharika reviewed May 18, 2020
View reviewed changes
examples/shared_samples/ethernet_network.rb Outdated
@@ -37,7 +37,7 @@
ethernet_class = OneviewSDK.resource_named('EthernetNetwork', @client.api_version)

# Scope class used in this sample
scope_class = OneviewSDK.resource_named('Scope', @client.api_version) unless @client.api_version.to_i <= 200
scope_class = OneviewSDK.resource_named('Scope', 1200) unless @client.api_version.to_i <= 200
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't hardcode this apiversion here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted back

chebroluharika
chebroluharika reviewed May 18, 2020
View reviewed changes
examples/shared_samples/fc_network.rb Outdated
@@ -37,14 +37,14 @@
fc_network_class = OneviewSDK.resource_named('FCNetwork', @client.api_version)

# Scope class used in this sample
scope_class = OneviewSDK.resource_named('Scope', @client.api_version) unless @client.api_version.to_i <= 200
scope_class = OneviewSDK.resource_named('Scope', 1200) unless @client.api_version.to_i <= 200
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above comment

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

chebroluharika
chebroluharika requested changes May 18, 2020
View reviewed changes
Copy link
Collaborator

@chebroluharika chebroluharika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change copyright years in all the files that you made change.

chebroluharika
chebroluharika reviewed May 18, 2020
View reviewed changes
endpoints-support.md Outdated
|<sub>/rest/ethernet-networks/bulk</sub> | POST | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: |
|<sub>/rest/ethernet-networks/{id}</sub> | GET | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: |
|<sub>/rest/ethernet-networks/{id}</sub> | PUT | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: |
|<sub>/rest/ethernet-networks/{id}</sub> | PATCH | :white_check_mark: | :white_check_mark: | :heavy_minus_sign: | :heavy_minus_sign: | :heavy_minus_sign: | :heavy_minus_sign: | :white_check_mark: |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this endpoint in API docs

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed PATCH for 1600

chebroluharika
chebroluharika reviewed May 18, 2020
View reviewed changes
endpoints-support.md Outdated
|<sub>/rest/fc-networks</sub> | GET | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: |
|<sub>/rest/fc-networks</sub> | POST | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: |
|<sub>/rest/fc-networks/{id}</sub> | GET | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: |
|<sub>/rest/fc-networks/{id}</sub> | PATCH | :white_check_mark: | :white_check_mark: | :heavy_minus_sign: | :heavy_minus_sign: | :heavy_minus_sign: | :heavy_minus_sign: | :white_check_mark: |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this endpoint in APIdocs. Please check.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

chebroluharika
chebroluharika reviewed May 18, 2020
View reviewed changes
endpoints-support.md Outdated
|<sub>/rest/fcoe-networks</sub> | GET | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: |
|<sub>/rest/fcoe-networks</sub> | POST | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: |
|<sub>/rest/fcoe-networks/{id}</sub> | GET | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: |
|<sub>/rest/fcoe-networks/{id}</sub> | PATCH | :white_check_mark: | :white_check_mark: | :heavy_minus_sign: | :heavy_minus_sign: | :heavy_minus_sign: | :heavy_minus_sign: | :white_check_mark: |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this endpoint in API docs. Please check.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

chebroluharika
chebroluharika requested changes May 18, 2020
View reviewed changes
Copy link
Collaborator

@chebroluharika chebroluharika left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't delete scope example file. Add spec files also for relevant resources.

chebroluharika
chebroluharika reviewed May 20, 2020
View reviewed changes
Copy link
Collaborator

@chebroluharika chebroluharika left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention working apiversions and api variants in example files properly before merging this.

@yuvirani yuvirani merged commit a85b823 into master May 20, 2020
@VenkateshRavula VenkateshRavula deleted the API1600/AllNetworks branch May 20, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chebroluharika chebroluharika chebroluharika approved these changes

@nabhajit-ray nabhajit-ray nabhajit-ray approved these changes

@AsisBagga AsisBagga Awaiting requested review from AsisBagga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yuvirani @chebroluharika @nabhajit-ray