Added API1600 support for HCP #421
Conversation
VenkateshRavula
requested review from
AsisBagga,
chebroluharika,
nabhajit-ray and
soodpr
| @@ -75,5 +79,7 @@ | |||
| puts "\nCompliance preview details are :\n#{cp}\n" | |||
|
|
|||
| # Deletes the created hypervisor cluster profile | |||
| hcp.delete | |||
| # Delete method accepts 2 optional arguments - soft_delete(boolean) and force(boolean) | |||
There was a problem hiding this comment.
Please mention that soft_delete is mandatory in 1600
| hcp.delete | ||
| # Delete method accepts 2 optional arguments - soft_delete(boolean) and force(boolean) | ||
| # The default values for both the arguments is "false" | ||
| hcp.delete(true, true) |
There was a problem hiding this comment.
Please try if hcp.delete(soft_delete = true, force = true) is working or not. If it is, change it accordingly.
| # Hypervisor cluster profile resource implementation for API1600 C7000 | ||
| class HypervisorClusterProfile < OneviewSDK::API1200::C7000::HypervisorClusterProfile | ||
|
|
||
| # Both softDelete and force are optional arguments but from API1600 softDelete is made mandatory argument |
There was a problem hiding this comment.
Please mention that "softDelete is mandatory in API1600"
| include_context 'shared context' | ||
|
|
||
| it 'inherits from OneviewSDK::API1000::Synergy::HypervisorClusterProfile' do | ||
| expect(described_class).to be < OneviewSDK::API1000::Synergy::HypervisorClusterProfile |
There was a problem hiding this comment.
I think it should inherit API1200::C7000 class. If so, please update description also accordingly.
There was a problem hiding this comment.
The respective lib file for API1200::Synergy file inherits from API1000::Synergy file, so mentioned the same in spec file.
| include_context 'shared context' | ||
|
|
||
| it 'inherits from OneviewSDK::API800::Synergy::HypervisorClusterProfile' do | ||
| expect(described_class).to be < OneviewSDK::API800::Synergy::HypervisorClusterProfile |
There was a problem hiding this comment.
I think it should inherit API1000::C7000 class. If so, please update description also accordingly.
There was a problem hiding this comment.
The respective lib file for API1000::Synergy file inherits from API800::Synergy file, so mentioned the same in spec file.
Description
Added API1600 support for HCP
Issues Resolved
Check List
$ rake test).