Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshot delete fix with correct etags #431

Merged
merged 7 commits into from
Jun 4, 2020
Merged

Snapshot delete fix with correct etags #431

merged 7 commits into from
Jun 4, 2020

Conversation

nabhajit-ray
Copy link
Collaborator

@nabhajit-ray nabhajit-ray commented Jun 3, 2020 •
edited

Description

[Snapshot delete fix with correct etags]

Issues Resolved

[It fixes the deletion of snapshot error due to mismatch etags #432 ]

Check List

  • New functionality includes testing.
    • All tests pass ($ rake test).
  • New functionality has been documented in the README if applicable.
    • New functionality has been thoroughly documented in the examples (please include helpful comments).
  • New endpoints supported are updated in the endpoints-support.md file.
  • Changes are documented in the CHANGELOG.

AsisBagga
AsisBagga approved these changes Jun 4, 2020
View reviewed changes
Copy link
Collaborator

@AsisBagga AsisBagga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nabhajit-ray nabhajit-ray merged commit 1795415 into master Jun 4, 2020
@nabhajit-ray nabhajit-ray deleted the Snapshot_delete_fix branch June 4, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuvirani yuvirani yuvirani approved these changes

@AsisBagga AsisBagga AsisBagga approved these changes

@chebroluharika chebroluharika Awaiting requested review from chebroluharika

@VenkateshRavula VenkateshRavula Awaiting requested review from VenkateshRavula

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nabhajit-ray @yuvirani @AsisBagga