Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR for config changes for Network resources #pr #477

Merged
merged 7 commits into from Nov 4, 2020
Merged

PR for config changes for Network resources #pr #477

merged 7 commits into from Nov 4, 2020

Conversation

chebroluharika
Copy link
Collaborator

@chebroluharika chebroluharika commented Nov 3, 2020 •
edited

Description

PR for config changes for following resources

  • Connection Templates
  • Enclosures
  • Enclosure Groups
  • Ethernet Network
  • FC Network
  • FCOE Network

Issues Resolved

NA

Check List

  • New functionality includes testing.
    • All tests pass ($ rake test).
  • New functionality has been documented in the README if applicable.
    • New functionality has been thoroughly documented in the examples (please include helpful comments).
  • New endpoints supported are updated in the endpoints-support.md file.
  • Changes are documented in the CHANGELOG.

yuvirani
yuvirani approved these changes Nov 3, 2020
View reviewed changes
Copy link
Collaborator

@yuvirani yuvirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chebroluharika chebroluharika merged commit 2fd37bf into master Nov 4, 2020
@chebroluharika chebroluharika deleted the feature branch November 4, 2020 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuvirani yuvirani yuvirani approved these changes

@VenkateshRavula VenkateshRavula VenkateshRavula approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chebroluharika @yuvirani @VenkateshRavula