-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
修改反馈文案 #3948
修改反馈文案 #3948
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am confused by this logic: this version is open source, so the problem is not caused by the launcher itself?
This is too absolute.
?这也太肯定了吧!为什么一个开源软件他的问题就不会是他引起的呢…… |
I was hoping to guide users that this version may be modified by other people, so it might not be the problem of this upstream repo... Maybe I can point out that this problem may not be the original repo's problem, and change it into this sort.
Thanks! @3gf8jv4dv @Deep-Dark-Forest |
This message is not use in a Release/Snapshot version of PCL. Only for Dev(Debug) version, or say self-compile. 这个信息不是给 Release/Snapshot 版本的 PCL 设置的。只是给 Dev(或者说 Debug)版本,即自行打包的版本。 |
Makes sense, but this version allows self-compilation, and we don't know if the code has changed |
@JingHai-Lingyun @wuliaodexiaoluo The text provided by the author later looks much better. For another question, maybe we can consider only stating in the code on the GitHub repo that the version may be modified by a third party. The local code of LTCatt remains unchanged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that is looking good. But we better listen to LTCatt.
Yes. I think this code will not be merged into the Release/Snapshot version, just only in this repo. |
I think it will not merge |
事实上这里没法放 “只对开源版生效” 的代码,因为我把代码同步过来的时候它就会被覆盖掉…… |
sodium(那)?1930? |
如文案需要改动请指出。感谢 qwq!