Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修改反馈文案 #3948

Closed
wants to merge 2 commits into from
Closed

修改反馈文案 #3948

wants to merge 2 commits into from

Conversation

youzi-2333
Copy link
Collaborator

如文案需要改动请指出。感谢 qwq!

Copy link
Collaborator

@3gf8jv4dv 3gf8jv4dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused by this logic: this version is open source, so the problem is not caused by the launcher itself?

This is too absolute.

@Deep-Dark-Forest
Copy link
Collaborator

?这也太肯定了吧!为什么一个开源软件他的问题就不会是他引起的呢……

@Deep-Dark-Forest Deep-Dark-Forest added the 等待反馈者 需要反馈者补充信息或配合测试 label Jun 1, 2024
@youzi-2333
Copy link
Collaborator Author

I am confused by this logic: this version is open source, so the problem is not caused by the launcher itself?

This is too absolute.

I was hoping to guide users that this version may be modified by other people, so it might not be the problem of this upstream repo...

Maybe I can point out that this problem may not be the original repo's problem, and change it into this sort.

此版本为开源版本,产生的 Bug 可能不是由原版 PCL 引起的。是否仍要打开反馈列表网页?

Thanks! @3gf8jv4dv @Deep-Dark-Forest

@JingHai-Lingyun
Copy link
Collaborator

This message is not use in a Release/Snapshot version of PCL. Only for Dev(Debug) version, or say self-compile.
In these versions, we are not sure is user modify the codes of it.

这个信息不是给 Release/Snapshot 版本的 PCL 设置的。只是给 Dev(或者说 Debug)版本,即自行打包的版本。
在这些版本中我们无法确认用户是否自行修改了代码内容

@Deep-Dark-Forest Deep-Dark-Forest added 等待确认 已经过社区确认,等待开发者确认 and removed 等待反馈者 需要反馈者补充信息或配合测试 labels Jun 1, 2024
@wuliaodexiaoluo
Copy link
Contributor

I am confused by this logic: this version is open source, so the problem is not caused by the launcher itself?

This is too absolute.

Makes sense, but this version allows self-compilation, and we don't know if the code has changed

@3gf8jv4dv
Copy link
Collaborator

@JingHai-Lingyun @wuliaodexiaoluo

The text provided by the author later looks much better.

For another question, maybe we can consider only stating in the code on the GitHub repo that the version may be modified by a third party. The local code of LTCatt remains unchanged.

Copy link
Collaborator

@3gf8jv4dv 3gf8jv4dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that is looking good. But we better listen to LTCatt.

@JingHai-Lingyun
Copy link
Collaborator

@JingHai-Lingyun @wuliaodexiaoluo

The text provided by the author later looks much better.

For another question, maybe we can consider only stating in the code on the GitHub repo that the version may be modified by a third party. The local code of LTCatt remains unchanged.

Yes. I think this code will not be merged into the Release/Snapshot version, just only in this repo.

@allMagicNB
Copy link
Contributor

allMagicNB commented Jun 1, 2024

I think it will not merge :trollface:

@LTCatt
Copy link
Member

LTCatt commented Jun 1, 2024

事实上这里没法放 “只对开源版生效” 的代码,因为我把代码同步过来的时候它就会被覆盖掉……

@LTCatt LTCatt closed this Jun 1, 2024
@Pigeon0v0 Pigeon0v0 added 拒绝 / 放弃 不会制作该功能或无法修复该 Bug and removed 等待确认 已经过社区确认,等待开发者确认 labels Jun 1, 2024
@wuliaodexiaoluo
Copy link
Contributor

sodium(那)?1930?

@youzi-2333 youzi-2333 deleted the feedback branch June 18, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
拒绝 / 放弃 不会制作该功能或无法修复该 Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants