Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to Offset not working for some values #48

Closed
kainjow opened this issue Nov 26, 2014 · 3 comments
Closed

Jump to Offset not working for some values #48

kainjow opened this issue Nov 26, 2014 · 3 comments

Comments

@kainjow
Copy link
Member

kainjow commented Nov 26, 2014

I have byte grouping set to 4, and if I jump to an offset that is the start of a row (e.g. 0, 16, 112, etc), I get an assert in updateSelectionPulse:461. In release mode that means the image has a height of 0 and then Cocoa throws an exception trying to lock focus on an invalid image size.

It seems e57b46e introduced the issue. @percontation what was that change for? The commit is vague. If I undo that commit, it works fine.

@percontation
Copy link
Contributor

The mechanism to restore focus to the non-banner view wasn't being applied to this particular banner; this commit added that in.

@percontation
Copy link
Contributor

Oh, and also, the selection pulse was modified to better reflect where activity was occurring. I guess that's the part that broke something.

@percontation
Copy link
Contributor

Okay, I see the problem, I'll push a fix.

percontation added a commit that referenced this issue Nov 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants